Allow Developers to Disable Selectize Autogrow #202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autogrow is an incredibly expensive operation when you're selectizing a large number of nodes (1000+). On such a page, disabling autogrow dropped selectize time from ~ 40s to ~ 2s.
|
👍 I needed this so I pulled down @farmdawgnation 's branch. Works great! |
Member
|
This should be fixed by #243. |
Author
|
Is disabling autogrow not a useful feature in its own right? |
|
I agree, disabling autoGrow entirely is definitely a useful feature. |
|
👍 Agreed that disabling autoGrow is useful (unless measureString could get even more performant) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are times autogrow isn't wanted and times the current autogrow implementation in Selectize.js causes serious performance issues. We had a page that was taking 40 seconds to Selectize around 1700 select boxes, and traced the hotspot back to the autogrow code in Selectize. With autogrow disabled, we were able to Selectize all of those boxes in around 2 seconds.