Improve setValue/addItems performance #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To see the performance benefits in the test case swap in this pull request's JS code instead of the master branch. |
Member
|
You're on fire, man! Thanks a bunch for this – looks great. |
Contributor
Author
|
Thanks to you for providing the only drop down hybrid control that could keep up with my use-case. Select2 and Choosen could not get out of their own way when there are "a lot" (>1000) of client side options to choose from. Its unfortunate because these 2 controls are the top hits for a google search. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance is improved for bulk inserts by delaying the processing of intermediate class updates and caret manipulations. This leads to significant performance improvements as demonstrated by the test case created for #423.