From 4c4061c1ad643aee473854f5ed1a6e1f0159c003 Mon Sep 17 00:00:00 2001
From: Naing Ye Lin Thein <NThein@hcf.com.au>
Date: Wed, 16 Oct 2019 11:40:58 +1100
Subject: [PATCH 1/2] print window opens before the page if fully loaded to fix
 this  issue using the window.onload event  instead of document.onload and
 adding the script with <script > tag after the </body> tag

---
 src/lib/ngx-print.directive.ts | 37 ++++++++++++++++++++--------------
 1 file changed, 22 insertions(+), 15 deletions(-)
diff --git a/src/lib/ngx-print.directive.ts b/src/lib/ngx-print.directive.ts
index 51441cf..c8f1d55 100644
--- a/src/lib/ngx-print.directive.ts
+++ b/src/lib/ngx-print.directive.ts
@@ -36,24 +36,24 @@ export class NgxPrintDirective {
   set printStyle(values: { [key: string]: { [key: string]: string } }) {
     for (let key in values) {
       if (values.hasOwnProperty(key)) {
-      this._printStyle.push((key + JSON.stringify(values[key])).replace(/['"]+/g, ''));
+        this._printStyle.push((key + JSON.stringify(values[key])).replace(/['"]+/g, ''));
       }
     }
     this.returnStyleValues();
   }
 
-/**
- *
- *
- * @returns the string that create the stylesheet which will be injected
- * later within <style></style> tag.
- *
- * -join/replace to transform an array objects to css-styled string
- *
- * @memberof NgxPrintDirective
- */
-public returnStyleValues() {
-  return `<style> ${this._printStyle.join(' ').replace(/,/g,';')} </style>`;
+  /**
+   *
+   *
+   * @returns the string that create the stylesheet which will be injected
+   * later within <style></style> tag.
+   *
+   * -join/replace to transform an array objects to css-styled string
+   *
+   * @memberof NgxPrintDirective
+   */
+  public returnStyleValues() {
+    return `<style> ${this._printStyle.join(' ').replace(/,/g, ';')} </style>`;
   }
 
   /**
@@ -110,7 +110,7 @@ public returnStyleValues() {
   public print(): void {
     let printContents, popupWin, styles = '', links = '';
 
-    if(this.useExistingCss) {
+    if (this.useExistingCss) {
       styles = this.getElementTag('style');
       links = this.getElementTag('link');
     }
@@ -127,9 +127,16 @@ public returnStyleValues() {
           ${styles}
           ${links}
         </head>
-        <body onload="window.print(); setTimeout(()=>{ window.close(); }, 0)">
+        <body>
           ${printContents}
         </body>
+        <script>
+            function openPrintWindow() {
+              window.print();
+              setTimeout(()=>{ window.close(); }, 0);
+            }
+            window.onload = openPrintWindow();
+        </script>
       </html>`);
     popupWin.document.close();
   }

From fab1dcfb515aeda58446554b4f4631f70a8c2188 Mon Sep 17 00:00:00 2001
From: Naing Ye Lin Thein <NThein@hcf.com.au>
Date: Wed, 16 Oct 2019 12:20:41 +1100
Subject: [PATCH 2/2] print window opens before page is fully loaded #55

to fix this  issue, change to the window.onload event  instead of document.onload and adding the script with <script > tag after the </body> tag"
---
 src/lib/ngx-print.directive.ts | 37 ++++++++++++++--------------------
 1 file changed, 15 insertions(+), 22 deletions(-)

diff --git a/src/lib/ngx-print.directive.ts b/src/lib/ngx-print.directive.ts
index c8f1d55..51441cf 100644
--- a/src/lib/ngx-print.directive.ts
+++ b/src/lib/ngx-print.directive.ts
@@ -36,24 +36,24 @@ export class NgxPrintDirective {
   set printStyle(values: { [key: string]: { [key: string]: string } }) {
     for (let key in values) {
       if (values.hasOwnProperty(key)) {
-        this._printStyle.push((key + JSON.stringify(values[key])).replace(/['"]+/g, ''));
+      this._printStyle.push((key + JSON.stringify(values[key])).replace(/['"]+/g, ''));
       }
     }
     this.returnStyleValues();
   }
 
-  /**
-   *
-   *
-   * @returns the string that create the stylesheet which will be injected
-   * later within <style></style> tag.
-   *
-   * -join/replace to transform an array objects to css-styled string
-   *
-   * @memberof NgxPrintDirective
-   */
-  public returnStyleValues() {
-    return `<style> ${this._printStyle.join(' ').replace(/,/g, ';')} </style>`;
+/**
+ *
+ *
+ * @returns the string that create the stylesheet which will be injected
+ * later within <style></style> tag.
+ *
+ * -join/replace to transform an array objects to css-styled string
+ *
+ * @memberof NgxPrintDirective
+ */
+public returnStyleValues() {
+  return `<style> ${this._printStyle.join(' ').replace(/,/g,';')} </style>`;
   }
 
   /**
@@ -110,7 +110,7 @@ export class NgxPrintDirective {
   public print(): void {
     let printContents, popupWin, styles = '', links = '';
 
-    if (this.useExistingCss) {
+    if(this.useExistingCss) {
       styles = this.getElementTag('style');
       links = this.getElementTag('link');
     }
@@ -127,16 +127,9 @@ export class NgxPrintDirective {
           ${styles}
           ${links}
         </head>
-        <body>
+        <body onload="window.print(); setTimeout(()=>{ window.close(); }, 0)">
           ${printContents}
         </body>
-        <script>
-            function openPrintWindow() {
-              window.print();
-              setTimeout(()=>{ window.close(); }, 0);
-            }
-            window.onload = openPrintWindow();
-        </script>
       </html>`);
     popupWin.document.close();
   }
