New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenide waits too much for collections #549

Closed
asolntsev opened this Issue Jun 16, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@asolntsev
Contributor

asolntsev commented Jun 16, 2017

Any collection check, like $$("tr").shouldHave(size(2)); wait too much.

This is because class ElementsCollection performs some extra sleep(collectionsPollingInterval);

Some time ago it was done because we hope to detect problems with collections that "probably will be loaded a bit later". But now we see that this causes Selenide slowness, and probably doesn't solve any real problems. Let's remove those extra sleeps.

@asolntsev asolntsev self-assigned this Jun 16, 2017

@asolntsev asolntsev added this to the 4.5 milestone Jun 16, 2017

@asolntsev asolntsev closed this in 1e9d83e Jun 17, 2017

asolntsev added a commit that referenced this issue Jun 17, 2017

Merge pull request #550 from codeborne/remove-extra-waits-for-collect…
…ions

fixes #549 Selenide waits too much for collections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment