New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh() this command is not working properly #740

Closed
sukhjinder-sdei opened this Issue May 17, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@sukhjinder-sdei

sukhjinder-sdei commented May 17, 2018

refresh() command is not refreshing web page, But if I use WebDriverRunner.getWebDriver().navigate().refresh(); then only page refresh.

Details

Environment

  • Selenide Version: 4.11.4
  • Chrome Version:66.0.3359.139
  • Browser Driver Version: 2.38
  • OS Version: Win10

Code To Reproduce Issue [ Good To Have ]

refresh()

@sukhjinder-sdei sukhjinder-sdei changed the title from refresh() this command is working properly to refresh() this command is not working properly May 17, 2018

@rosolko

This comment has been minimized.

Collaborator

rosolko commented May 17, 2018

@sukhjinder-sdei Thanks, I'm look at the implementation and for now it's looks like:

public static void refresh() {
  navigator.open(url());
}

public static String url() {
  return webdriverContainer.getCurrentUrl();
}

@asolntsev @BorisOsipov Can you please sync knowledges -- why do we open current url instead of refresh page?

@rosolko rosolko added this to the 4.11.5 milestone May 17, 2018

@rosolko rosolko added bug 🐛 and removed bug 🐛 labels May 17, 2018

@sukhjinder-sdei

This comment has been minimized.

sukhjinder-sdei commented May 17, 2018

@rosolko Thanks for ur quick response.

@BorisOsipov

This comment has been minimized.

Member

BorisOsipov commented May 17, 2018

@rosolko I see that this code is five year old. Maybe refresh did't work well 5 years ago...
Don't find any reason to keep it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment