Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to enable/disable proxy server #788

Closed
asolntsev opened this Issue Aug 27, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@asolntsev
Copy link
Contributor

asolntsev commented Aug 27, 2018

Selenide can run its own proxy server.
Initially it was used only for downloading files. That's why proxy server is currently enabled/disabled by setting Configuration.fileDownload. But now proxy can used for different purposes. That's why it's reasonable to introduce a dedicated setting for proxy server:

  • proxyEnabled=true | false // default value: false
  • proxyHost=localhost // default value: null (meaning that Selenide will try to detect IP automatically)
  • proxyPort=8080 // default value: 0 (meaning that Selenide will select a random free port)

@asolntsev asolntsev self-assigned this Aug 27, 2018

@asolntsev asolntsev added the feature label Aug 27, 2018

@asolntsev asolntsev added this to the 4.14.0 milestone Aug 27, 2018

asolntsev added a commit that referenced this issue Aug 28, 2018

asolntsev added a commit that referenced this issue Aug 28, 2018

@asolntsev

This comment has been minimized.

Copy link
Contributor Author

asolntsev commented Aug 28, 2018

Done in #791

@asolntsev asolntsev closed this Aug 28, 2018

asolntsev added a commit that referenced this issue Aug 28, 2018

#788 Add setting to enable/disable proxy server (#791)
* #788 Add setting to enable/disable proxy server

* #788 remove unneeded else blocks

asolntsev added a commit that referenced this issue Aug 28, 2018

asolntsev added a commit that referenced this issue Aug 28, 2018

#788 ignore all proxy-related tests in PhantomJS
I don't know why, but PhantomJS seems to ignore proxy

asolntsev added a commit that referenced this issue Aug 28, 2018

asolntsev added a commit that referenced this issue Aug 28, 2018

#788 ignore all proxy-related tests in PhantomJS
I don't know why, but PhantomJS seems to ignore proxy

asolntsev added a commit that referenced this issue Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.