Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1946 deep shadow selectors support #1947

Merged
merged 2 commits into from Sep 19, 2022
Merged

#1946 deep shadow selectors support #1947

merged 2 commits into from Sep 19, 2022

Conversation

BorisOsipov
Copy link
Member

@BorisOsipov BorisOsipov commented Sep 6, 2022 •
edited

Proposed changes

Implements #1946

Checklist

  • Checkstyle and unit tests are passed locally with my changes by running gradlew check chrome_headless firefox_headless command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@BorisOsipov BorisOsipov self-assigned this Sep 6, 2022
@BorisOsipov BorisOsipov added this to the 6.8.0 milestone Sep 6, 2022
@BorisOsipov BorisOsipov force-pushed the test-deep-shadow branch 4 times, most recently from 4f50592 to e90bbc2 Compare September 6, 2022 15:37
@selenide selenide deleted a comment from sonarcloud bot Sep 6, 2022
@selenide selenide deleted a comment from sonarcloud bot Sep 6, 2022
@BorisOsipov BorisOsipov force-pushed the test-deep-shadow branch 3 times, most recently from b63e7d6 to 5ce5e03 Compare September 6, 2022 17:07
@BorisOsipov BorisOsipov marked this pull request as ready for review September 6, 2022 17:07
@BorisOsipov
Copy link
Member Author

Could not bypass sonarcloud check. It fails due transpiled js code but I cannot exclude that file not by code-analysis.gradle not by sonar-project.properties 😟

asolntsev
asolntsev requested changes Sep 7, 2022
View reviewed changes
Copy link
Member

@asolntsev asolntsev left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BorisOsipov PR is good, but this 3rd-party JS is unreadable.
Can't we just write a simple JS to iterate all DOM elements, like https://github.com/selenide/selenide/blob/master/src/main/resources/find-elements-by-text-case-insensitive.js ?

@asolntsev
Copy link
Member

but I cannot exclude that file

Can't you ignore the Sonar error by this hack?

// @SONAR_STOP@
code to ignore
// @SONAR_START@

See https://community.sonarsource.com/t/sonar-ignore-issues-by-block-not-working/27008/6

@BorisOsipov
Copy link
Member Author

@asolntsev it doesn't work without additional setup https://community.sonarsource.com/t/sonar-ignore-issues-by-block-not-working/27008/2

@BorisOsipov BorisOsipov force-pushed the test-deep-shadow branch 7 times, most recently from c6f1454 to ab30377 Compare September 14, 2022 12:08
@BorisOsipov
Copy link
Member Author

@asolntsev

PR is good, but this 3rd-party JS is unreadable.

fixed

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

rosolko
rosolko approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@rosolko rosolko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@asolntsev asolntsev merged commit 3cc39a8 into master Sep 19, 2022
@asolntsev asolntsev deleted the test-deep-shadow branch September 19, 2022 13:00
@asolntsev asolntsev linked an issue Sep 19, 2022 that may be closed by this pull request
Implement deep Shadow DOM selectors #1946
Closed
@asolntsev asolntsev mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asolntsev asolntsev asolntsev approved these changes

@rosolko rosolko rosolko approved these changes

@dstekanov dstekanov Awaiting requested review from dstekanov

Assignees

@BorisOsipov BorisOsipov

Labels
feature
Projects
None yet
Milestone
6.8.0
Development

Successfully merging this pull request may close these issues.

Implement deep Shadow DOM selectors
3 participants
@BorisOsipov @asolntsev @rosolko