New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#528 - Wrong ElementNotFound exception message #530

Merged
merged 1 commit into from Jul 3, 2017

Conversation

Projects
None yet
4 participants
@BorisOsipov
Member

BorisOsipov commented May 11, 2017

Show a corresponding option text or index in NotFoundException instead of a select locator in case when option doesn't exists in the select.

#528 Wrong ElementNotFound exception message
- Show a corresponding option text or index in NotFoundException instead of a select locator in case when option doesn't exists in the select
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 11, 2017

Coverage Status

Coverage increased (+0.09%) to 62.997% when pulling 607ee8c on BorisOsipov:528 into 8463167 on codeborne:master.

coveralls commented May 11, 2017

Coverage Status

Coverage increased (+0.09%) to 62.997% when pulling 607ee8c on BorisOsipov:528 into 8463167 on codeborne:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io May 11, 2017

Codecov Report

Merging #530 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #530      +/-   ##
===========================================
+ Coverage     58.85%   58.9%   +0.05%     
+ Complexity      691     690       -1     
===========================================
  Files           131     131              
  Lines          2610    2616       +6     
  Branches        264     264              
===========================================
+ Hits           1536    1541       +5     
  Misses          968     968              
- Partials        106     107       +1
Impacted Files Coverage Δ Complexity Δ
...e/selenide/commands/SelectOptionByTextOrIndex.java 100% <100%> (ø) 7 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 77.77% <0%> (-0.7%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8463167...607ee8c. Read the comment docs.

codecov-io commented May 11, 2017

Codecov Report

Merging #530 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #530      +/-   ##
===========================================
+ Coverage     58.85%   58.9%   +0.05%     
+ Complexity      691     690       -1     
===========================================
  Files           131     131              
  Lines          2610    2616       +6     
  Branches        264     264              
===========================================
+ Hits           1536    1541       +5     
  Misses          968     968              
- Partials        106     107       +1
Impacted Files Coverage Δ Complexity Δ
...e/selenide/commands/SelectOptionByTextOrIndex.java 100% <100%> (ø) 7 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 77.77% <0%> (-0.7%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8463167...607ee8c. Read the comment docs.

@asolntsev asolntsev self-requested a review Jul 3, 2017

@asolntsev asolntsev self-assigned this Jul 3, 2017

@asolntsev asolntsev added this to the 4.6 milestone Jul 3, 2017

@asolntsev asolntsev merged commit e269f79 into selenide:master Jul 3, 2017

4 checks passed

codecov/patch 100% of diff hit (target 58.85%)
Details
codecov/project 58.9% (+0.05%) compared to 8463167
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 62.997%
Details

asolntsev added a commit that referenced this pull request Jul 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment