New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser capabilities configuration section added #556

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@SergeyPirogov
Collaborator

SergeyPirogov commented Jun 18, 2017

Need to add merge for chrome and firefox capabilities !!!

@SergeyPirogov

This comment has been minimized.

Show comment
Hide comment
@SergeyPirogov

SergeyPirogov Jun 18, 2017

Collaborator

Changes from this PR will help people to set custom capabilities for custom Chrome options or Firefox profies and avoid people adding PR's such as this one https://github.com/codeborne/selenide/pull/546/files

Collaborator

SergeyPirogov commented Jun 18, 2017

Changes from this PR will help people to set custom capabilities for custom Chrome options or Firefox profies and avoid people adding PR's such as this one https://github.com/codeborne/selenide/pull/546/files

Browser capabilities configuration section added for all browsers
Browser capabilities configuration section added for all browsers

Browser capabilities configuration section added for all browsers

Browser capabilities configuration section added
@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Oct 7, 2017

Contributor

@SergeyPirogov This PR has conflicts with master branch. Could you resolve it?

Contributor

asolntsev commented Oct 7, 2017

@SergeyPirogov This PR has conflicts with master branch. Could you resolve it?

@taeunChoi

This comment has been minimized.

Show comment
Hide comment
@taeunChoi

taeunChoi Nov 27, 2017

Is this feature added to the release version?

taeunChoi commented Nov 27, 2017

Is this feature added to the release version?

@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Dec 3, 2017

Contributor

@taeunChoi This PR is not merged yet. We need to resolve conflicts first.

Contributor

asolntsev commented Dec 3, 2017

@taeunChoi This PR is not merged yet. We need to resolve conflicts first.

@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Dec 3, 2017

Contributor

@SergeyPirogov This PR has conflicts with master branch. Could you resolve it?

Contributor

asolntsev commented Dec 3, 2017

@SergeyPirogov This PR has conflicts with master branch. Could you resolve it?

@SergeyPirogov

This comment has been minimized.

Show comment
Hide comment
@SergeyPirogov

SergeyPirogov Dec 4, 2017

Collaborator

@asolntsev Webdriverfactory were rewritten and now as I understand logic splitted to DriverFactories. So it will take some time to fix this PR

Collaborator

SergeyPirogov commented Dec 4, 2017

@asolntsev Webdriverfactory were rewritten and now as I understand logic splitted to DriverFactories. So it will take some time to fix this PR

@BorisOsipov BorisOsipov referenced this pull request Jan 4, 2018

Merged

Browser capabilities configuration section added #664

3 of 3 tasks complete
@BorisOsipov

This comment has been minimized.

Show comment
Hide comment
@BorisOsipov

BorisOsipov Jan 4, 2018

Member

It was rewritten in #664

Member

BorisOsipov commented Jan 4, 2018

It was rewritten in #664

@BorisOsipov BorisOsipov closed this Jan 4, 2018

@asolntsev asolntsev added the feature label Jan 5, 2018

@asolntsev asolntsev added this to the 4.10 milestone Jan 5, 2018

@user667 user667 referenced this pull request Jan 21, 2018

Closed

#675: Chrome browser gets maximized #680

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment