New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set browser binary path using configuration parameter. #627

Merged
merged 3 commits into from Oct 24, 2017

Conversation

Projects
None yet
4 participants
@ostap-oleksyn
Contributor

ostap-oleksyn commented Oct 24, 2017

Proposed changes

Sometimes there is a need to run some tests locally using different browser version. To do that you need to explicitly set browser binary path. These changes add a "browserBinary" parameter which can be used to set browser executable path. Works only for Firefox, Chrome and Opera, since other browsers don't support custom binary path.

Checklist

  • [x ] Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] I have added necessary documentation (if appropriate)
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 24, 2017

Coverage Status

Coverage decreased (-0.09%) to 64.281% when pulling a45c1c8 on ostap-oleksyn:browser_binary into e4e189d on codeborne:master.

coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.09%) to 64.281% when pulling a45c1c8 on ostap-oleksyn:browser_binary into e4e189d on codeborne:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 24, 2017

Codecov Report

Merging #627 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #627      +/-   ##
============================================
- Coverage     60.58%   60.42%   -0.16%     
  Complexity      771      771              
============================================
  Files           148      148              
  Lines          2745     2752       +7     
  Branches        269      272       +3     
============================================
  Hits           1663     1663              
- Misses          978      983       +5     
- Partials        104      106       +2
Impacted Files Coverage Δ Complexity Δ
...eborne/selenide/webdriver/ChromeDriverFactory.java 78.57% <0%> (-6.05%) 8 <0> (ø)
...deborne/selenide/webdriver/OperaDriverFactory.java 25% <0%> (-8.34%) 2 <0> (ø)
...borne/selenide/webdriver/FirefoxDriverFactory.java 81.81% <0%> (-5.28%) 9 <0> (ø)
...ain/java/com/codeborne/selenide/Configuration.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e189d...a45c1c8. Read the comment docs.

codecov-io commented Oct 24, 2017

Codecov Report

Merging #627 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #627      +/-   ##
============================================
- Coverage     60.58%   60.42%   -0.16%     
  Complexity      771      771              
============================================
  Files           148      148              
  Lines          2745     2752       +7     
  Branches        269      272       +3     
============================================
  Hits           1663     1663              
- Misses          978      983       +5     
- Partials        104      106       +2
Impacted Files Coverage Δ Complexity Δ
...eborne/selenide/webdriver/ChromeDriverFactory.java 78.57% <0%> (-6.05%) 8 <0> (ø)
...deborne/selenide/webdriver/OperaDriverFactory.java 25% <0%> (-8.34%) 2 <0> (ø)
...borne/selenide/webdriver/FirefoxDriverFactory.java 81.81% <0%> (-5.28%) 9 <0> (ø)
...ain/java/com/codeborne/selenide/Configuration.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e189d...a45c1c8. Read the comment docs.

@asolntsev asolntsev self-assigned this Oct 24, 2017

@asolntsev asolntsev added the feature label Oct 24, 2017

@asolntsev asolntsev added this to the 4.9 milestone Oct 24, 2017

@asolntsev asolntsev merged commit b7fe2c7 into selenide:master Oct 24, 2017

1 of 4 checks passed

codecov/patch 0% of diff hit (target 60.58%)
Details
codecov/project 60.42% (-0.16%) compared to e4e189d
Details
coverage/coveralls Coverage decreased (-0.09%) to 64.281%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment