New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prompt() in HtmlUnit (new driver version 2.28.1) + new tests in AlertTest #634

Merged
merged 3 commits into from Nov 23, 2017

Conversation

Projects
None yet
5 participants
@simple-elf
Contributor

simple-elf commented Nov 21, 2017

Proposed changes

Fix HtmlUnit issues in PR #591.

Changed method supportsModalDialogs() from WebDriverRunner.java, because now HtmlUnit 2.28 supports both alert() and prompt().

Update page_with_alerts for new prompt() test.
New test waitsUntilPromptDialogAppears() in AlertTest for prompt() with timeout.
Unignore test canSubmitPromptDialog() form HtmlUnit.

Ignore userCanAddAnyCustomCommandsToSelenide() in CustomCommandsTest for HtmlUnit.

UPD:
new test canSubmitPromptDialogWithDefaultValue() in AlertTest

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
@simple-elf

This comment has been minimized.

Show comment
Hide comment
@simple-elf
Contributor

simple-elf commented Nov 21, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 21, 2017

Coverage Status

Coverage remained the same at 64.281% when pulling 27afd40 on simple-elf:master into 6f036e1 on codeborne:master.

coveralls commented Nov 21, 2017

Coverage Status

Coverage remained the same at 64.281% when pulling 27afd40 on simple-elf:master into 6f036e1 on codeborne:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 21, 2017

Codecov Report

Merging #634 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #634      +/-   ##
============================================
- Coverage     60.53%   60.42%   -0.11%     
+ Complexity      772      771       -1     
============================================
  Files           148      148              
  Lines          2752     2752              
  Branches        272      272              
============================================
- Hits           1666     1663       -3     
- Misses          981      984       +3     
  Partials        105      105
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/codeborne/selenide/Selenide.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/com/codeborne/selenide/WebDriverRunner.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 80.43% <0%> (-2.18%) 30% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d40bf1...d542ed6. Read the comment docs.

codecov-io commented Nov 21, 2017

Codecov Report

Merging #634 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #634      +/-   ##
============================================
- Coverage     60.53%   60.42%   -0.11%     
+ Complexity      772      771       -1     
============================================
  Files           148      148              
  Lines          2752     2752              
  Branches        272      272              
============================================
- Hits           1666     1663       -3     
- Misses          981      984       +3     
  Partials        105      105
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/codeborne/selenide/Selenide.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/com/codeborne/selenide/WebDriverRunner.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 80.43% <0%> (-2.18%) 30% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d40bf1...d542ed6. Read the comment docs.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 21, 2017

Coverage Status

Coverage remained the same at 64.281% when pulling 2b77bde on simple-elf:master into 6f036e1 on codeborne:master.

coveralls commented Nov 21, 2017

Coverage Status

Coverage remained the same at 64.281% when pulling 2b77bde on simple-elf:master into 6f036e1 on codeborne:master.

@asolntsev asolntsev self-assigned this Nov 21, 2017

@asolntsev asolntsev added this to the 4.9 milestone Nov 21, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 22, 2017

Coverage Status

Coverage decreased (-0.1%) to 64.244% when pulling d542ed6 on simple-elf:master into 2d40bf1 on codeborne:master.

coveralls commented Nov 22, 2017

Coverage Status

Coverage decreased (-0.1%) to 64.244% when pulling d542ed6 on simple-elf:master into 2d40bf1 on codeborne:master.

@BorisOsipov

This comment has been minimized.

Show comment
Hide comment
@BorisOsipov

BorisOsipov Nov 22, 2017

Member

I fixed problem in test with new HtmlUnit in #636
Let's remove https://github.com/codeborne/selenide/pull/634/files#diff-8ca6de195fc23b2f64e9c5adedb915a5R26
after merging.

Member

BorisOsipov commented Nov 22, 2017

I fixed problem in test with new HtmlUnit in #636
Let's remove https://github.com/codeborne/selenide/pull/634/files#diff-8ca6de195fc23b2f64e9c5adedb915a5R26
after merging.

@asolntsev asolntsev merged commit 422b4bd into selenide:master Nov 23, 2017

1 of 4 checks passed

codecov/patch 0% of diff hit (target 60.53%)
Details
codecov/project 60.42% (-0.11%) compared to 2d40bf1
Details
coverage/coveralls Coverage decreased (-0.1%) to 64.244%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Nov 23, 2017

Contributor

@simple-elf Thank you! Merged.

Contributor

asolntsev commented Nov 23, 2017

@simple-elf Thank you! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment