New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to scroll into view related to #649 #656

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
5 participants
@rosolko
Collaborator

rosolko commented Dec 28, 2017

Proposed changes

Add command to scroll into view related to #649

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 28, 2017

Coverage Status

Coverage increased (+0.06%) to 64.379% when pulling 01d2186 on rosolko:scroll_into_view into 5a8d489 on codeborne:master.

coveralls commented Dec 28, 2017

Coverage Status

Coverage increased (+0.06%) to 64.379% when pulling 01d2186 on rosolko:scroll_into_view into 5a8d489 on codeborne:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 28, 2017

Codecov Report

Merging #656 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #656      +/-   ##
============================================
+ Coverage     60.43%   60.56%   +0.13%     
- Complexity      770      773       +3     
============================================
  Files           148      149       +1     
  Lines          2750     2754       +4     
  Branches        270      270              
============================================
+ Hits           1662     1668       +6     
+ Misses          982      981       -1     
+ Partials        106      105       -1
Impacted Files Coverage Δ Complexity Δ
...om/codeborne/selenide/commands/ScrollIntoView.java 100% <100%> (ø) 2 <2> (?)
...java/com/codeborne/selenide/commands/Commands.java 97.93% <100%> (+0.02%) 17 <0> (ø) ⬇️
...codeborne/selenide/webdriver/WebDriverFactory.java 85.45% <0%> (+3.31%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ba5a8...01d2186. Read the comment docs.

codecov-io commented Dec 28, 2017

Codecov Report

Merging #656 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #656      +/-   ##
============================================
+ Coverage     60.43%   60.56%   +0.13%     
- Complexity      770      773       +3     
============================================
  Files           148      149       +1     
  Lines          2750     2754       +4     
  Branches        270      270              
============================================
+ Hits           1662     1668       +6     
+ Misses          982      981       -1     
+ Partials        106      105       -1
Impacted Files Coverage Δ Complexity Δ
...om/codeborne/selenide/commands/ScrollIntoView.java 100% <100%> (ø) 2 <2> (?)
...java/com/codeborne/selenide/commands/Commands.java 97.93% <100%> (+0.02%) 17 <0> (ø) ⬇️
...codeborne/selenide/webdriver/WebDriverFactory.java 85.45% <0%> (+3.31%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ba5a8...01d2186. Read the comment docs.

@BorisOsipov BorisOsipov self-requested a review Dec 28, 2017

@BorisOsipov

This comment has been minimized.

Show comment
Hide comment
@BorisOsipov

BorisOsipov Dec 28, 2017

Member

@rosolko Thank you for the pull request. It has awesome documentation.

P.S. For future, please, separate functional changes and fixing unrelated formatting issues.

Member

BorisOsipov commented Dec 28, 2017

@rosolko Thank you for the pull request. It has awesome documentation.

P.S. For future, please, separate functional changes and fixing unrelated formatting issues.

@BorisOsipov BorisOsipov added the ready label Dec 28, 2017

@rosolko

This comment has been minimized.

Show comment
Hide comment
@rosolko

rosolko Dec 28, 2017

Collaborator

@BorisOsipov Sorry about formatting. I've added local .editorconfig and it perform trim whitespaces and insert newline at the file end automatically on file save.

Collaborator

rosolko commented Dec 28, 2017

@BorisOsipov Sorry about formatting. I've added local .editorconfig and it perform trim whitespaces and insert newline at the file end automatically on file save.

@BorisOsipov

This comment has been minimized.

Show comment
Hide comment
@BorisOsipov

BorisOsipov Dec 28, 2017

Member

@rosolko no problems :).

Btw Is it good .editorconfig? I mean is it suitable for project code style? Maybe we can commit it and use?

Member

BorisOsipov commented Dec 28, 2017

@rosolko no problems :).

Btw Is it good .editorconfig? I mean is it suitable for project code style? Maybe we can commit it and use?

@BorisOsipov BorisOsipov removed their request for review Dec 28, 2017

@rosolko

This comment has been minimized.

Show comment
Hide comment
@rosolko

rosolko Dec 28, 2017

Collaborator

@BorisOsipov
From my point this file is must have.
It automatically do a lot of work for me.
For example I'm using 4 space indent at most of the project but here 2 space is a standard, but this file can avoid all problem and do a lot of dirty work for me.
For example, locally I'm using this config to match project code style:

root = true

[*]
indent_style = space
indent_size = 2
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

I can create PR with this file and perform code reformat related to style.
Basically, all contributor by default will use this code style without any config.

Collaborator

rosolko commented Dec 28, 2017

@BorisOsipov
From my point this file is must have.
It automatically do a lot of work for me.
For example I'm using 4 space indent at most of the project but here 2 space is a standard, but this file can avoid all problem and do a lot of dirty work for me.
For example, locally I'm using this config to match project code style:

root = true

[*]
indent_style = space
indent_size = 2
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

I can create PR with this file and perform code reformat related to style.
Basically, all contributor by default will use this code style without any config.

@BorisOsipov

This comment has been minimized.

Show comment
Hide comment
@BorisOsipov

BorisOsipov Dec 28, 2017

Member

Yeah I know what editorconf does.

perform code reformat related to style.

It will produce huge reformatting changes. I will create issue and think about how we can do it easier.
Thank you for this idea!

Member

BorisOsipov commented Dec 28, 2017

Yeah I know what editorconf does.

perform code reformat related to style.

It will produce huge reformatting changes. I will create issue and think about how we can do it easier.
Thank you for this idea!

asolntsev added a commit that referenced this pull request Jan 8, 2018

@asolntsev asolntsev referenced this pull request Jan 8, 2018

Merged

#658 Add .editorconfig file to the project #670

1 of 3 tasks complete

@asolntsev asolntsev self-requested a review Jan 9, 2018

@asolntsev asolntsev self-assigned this Jan 9, 2018

@asolntsev

@BorisOsipov The change itself seems OK to me. Should we merge it?

@BorisOsipov

This comment has been minimized.

Show comment
Hide comment
@BorisOsipov
Member

BorisOsipov commented Jan 9, 2018

@BorisOsipov BorisOsipov merged commit 95ef5aa into selenide:master Jan 10, 2018

4 checks passed

codecov/patch 100% of diff hit (target 60.43%)
Details
codecov/project 60.56% (+0.13%) compared to 70ba5a8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 64.379%
Details
@BorisOsipov

This comment has been minimized.

Show comment
Hide comment
@BorisOsipov

BorisOsipov Jan 10, 2018

Member

@rosolko Thank you

Member

BorisOsipov commented Jan 10, 2018

@rosolko Thank you

@rosolko rosolko deleted the rosolko:scroll_into_view branch Jan 10, 2018

@asolntsev asolntsev added this to the 4.10 milestone Jan 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment