New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get current "User-Agent" for browser session. Related to #639 #657

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@rosolko
Collaborator

rosolko commented Dec 28, 2017

Proposed changes

Add "User-Agent" header when downloading file. Related to #639

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
Add ability to get UserAgent.
Set User-Agent for HttpGet in DownloadFileWithHttpRequest.

@rosolko rosolko changed the title from Add ability to get current "User-Agent" for browser session to Add ability to get current "User-Agent" for browser session. Related to #639 Dec 28, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 28, 2017

Coverage Status

Coverage increased (+0.03%) to 64.34% when pulling ee488d3 on rosolko:user_agent into 5a8d489 on codeborne:master.

coveralls commented Dec 28, 2017

Coverage Status

Coverage increased (+0.03%) to 64.34% when pulling ee488d3 on rosolko:user_agent into 5a8d489 on codeborne:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 28, 2017

Codecov Report

Merging #657 into master will increase coverage by 0.1%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #657     +/-   ##
===========================================
+ Coverage     60.49%   60.59%   +0.1%     
- Complexity      771      772      +1     
===========================================
  Files           148      148             
  Lines          2749     2751      +2     
  Branches        270      270             
===========================================
+ Hits           1663     1667      +4     
+ Misses          981      980      -1     
+ Partials        105      104      -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/codeborne/selenide/Selenide.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rne/selenide/impl/DownloadFileWithHttpRequest.java 79.72% <100%> (+0.27%) 15 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 82.6% <0%> (+2.17%) 31% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8d489...607eef0. Read the comment docs.

codecov-io commented Dec 28, 2017

Codecov Report

Merging #657 into master will increase coverage by 0.1%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #657     +/-   ##
===========================================
+ Coverage     60.49%   60.59%   +0.1%     
- Complexity      771      772      +1     
===========================================
  Files           148      148             
  Lines          2749     2751      +2     
  Branches        270      270             
===========================================
+ Hits           1663     1667      +4     
+ Misses          981      980      -1     
+ Partials        105      104      -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/codeborne/selenide/Selenide.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rne/selenide/impl/DownloadFileWithHttpRequest.java 79.72% <100%> (+0.27%) 15 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 82.6% <0%> (+2.17%) 31% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8d489...607eef0. Read the comment docs.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 28, 2017

Coverage Status

Coverage increased (+0.06%) to 64.377% when pulling 607eef0 on rosolko:user_agent into 5a8d489 on codeborne:master.

coveralls commented Dec 28, 2017

Coverage Status

Coverage increased (+0.06%) to 64.377% when pulling 607eef0 on rosolko:user_agent into 5a8d489 on codeborne:master.

@rosolko

This comment has been minimized.

Show comment
Hide comment
@rosolko

rosolko Dec 29, 2017

Collaborator

I don't know why reason, but codecov/patch won't pass :(

Collaborator

rosolko commented Dec 29, 2017

I don't know why reason, but codecov/patch won't pass :(

@BorisOsipov

This comment has been minimized.

Show comment
Hide comment
@BorisOsipov

BorisOsipov Dec 29, 2017

Member

@rosolko relax and don't care :)

Member

BorisOsipov commented Dec 29, 2017

@rosolko relax and don't care :)

@BorisOsipov

This comment has been minimized.

Show comment
Hide comment
@BorisOsipov

BorisOsipov Jan 3, 2018

Member

Thanks @rosolko
Merged b9a8840

Member

BorisOsipov commented Jan 3, 2018

Thanks @rosolko
Merged b9a8840

@BorisOsipov BorisOsipov closed this Jan 3, 2018

@rosolko rosolko deleted the rosolko:user_agent branch Jan 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment