New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #660 - Remote driver factory should take into account headless option #661

Merged
merged 3 commits into from Jan 6, 2018

Conversation

Projects
None yet
4 participants
@BorisOsipov
Member

BorisOsipov commented Jan 3, 2018

Proposed changes

Fix #660
Remote driver factory should take into account headless option.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
Fix #660 - Remote driver factory should take into account headless op…
…tion

Signed-off-by: Boris Osipov <osipov.boris@gmail.com>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 3, 2018

Coverage Status

Coverage increased (+0.2%) to 64.502% when pulling b99ceb2 on #660_headless_remote_driver into d1aee69 on master.

coveralls commented Jan 3, 2018

Coverage Status

Coverage increased (+0.2%) to 64.502% when pulling b99ceb2 on #660_headless_remote_driver into d1aee69 on master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 3, 2018

Codecov Report

Merging #661 into master will increase coverage by 0.18%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #661      +/-   ##
============================================
+ Coverage     60.44%   60.62%   +0.18%     
- Complexity      771      775       +4     
============================================
  Files           148      148              
  Lines          2763     2776      +13     
  Branches        270      272       +2     
============================================
+ Hits           1670     1683      +13     
+ Misses          986      985       -1     
- Partials        107      108       +1
Impacted Files Coverage Δ Complexity Δ
...eborne/selenide/webdriver/RemoteDriverFactory.java 68.75% <80%> (+16.11%) 11 <4> (+4) ⬆️
...e/selenide/impl/WebDriverThreadLocalContainer.java 80.43% <0%> (+0.72%) 30% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cbc887...86cb897. Read the comment docs.

codecov-io commented Jan 3, 2018

Codecov Report

Merging #661 into master will increase coverage by 0.18%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #661      +/-   ##
============================================
+ Coverage     60.44%   60.62%   +0.18%     
- Complexity      771      775       +4     
============================================
  Files           148      148              
  Lines          2763     2776      +13     
  Branches        270      272       +2     
============================================
+ Hits           1670     1683      +13     
+ Misses          986      985       -1     
- Partials        107      108       +1
Impacted Files Coverage Δ Complexity Δ
...eborne/selenide/webdriver/RemoteDriverFactory.java 68.75% <80%> (+16.11%) 11 <4> (+4) ⬆️
...e/selenide/impl/WebDriverThreadLocalContainer.java 80.43% <0%> (+0.72%) 30% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cbc887...86cb897. Read the comment docs.

@BorisOsipov BorisOsipov added the ready label Jan 4, 2018

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 6, 2018

Coverage Status

Coverage increased (+0.2%) to 64.517% when pulling 86cb897 on #660_headless_remote_driver into 0cbc887 on master.

coveralls commented Jan 6, 2018

Coverage Status

Coverage increased (+0.2%) to 64.517% when pulling 86cb897 on #660_headless_remote_driver into 0cbc887 on master.

@asolntsev asolntsev added this to the 4.10 milestone Jan 6, 2018

@asolntsev asolntsev self-requested a review Jan 6, 2018

@asolntsev

It used TestNG annotation @AfterTest instead of JUnit one @After. I fixed it.

@asolntsev asolntsev self-assigned this Jan 6, 2018

@asolntsev asolntsev merged commit 86b2572 into master Jan 6, 2018

4 checks passed

codecov/patch 80% of diff hit (target 60.44%)
Details
codecov/project 60.62% (+0.18%) compared to 0cbc887
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 64.517%
Details

@asolntsev asolntsev deleted the #660_headless_remote_driver branch Jan 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment