New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser capabilities configuration section added #664

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
5 participants
@BorisOsipov
Member

BorisOsipov commented Jan 4, 2018

Proposed changes

I ported сhanges from #556 to current master
Changes from this PR will help people to set custom capabilities for custom Chrome options or Firefox profie

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
Browser capabilities configuration section added
Signed-off-by: Boris Osipov <osipov.boris@gmail.com>
@BorisOsipov

This comment has been minimized.

Show comment
Hide comment
@BorisOsipov

BorisOsipov Jan 4, 2018

Member

@SergeyPirogov please review changes.

Member

BorisOsipov commented Jan 4, 2018

@SergeyPirogov please review changes.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 4, 2018

Codecov Report

Merging #664 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #664      +/-   ##
===========================================
- Coverage     60.52%   60.4%   -0.12%     
+ Complexity      771     770       -1     
===========================================
  Files           148     148              
  Lines          2761    2763       +2     
  Branches        270     270              
===========================================
- Hits           1671    1669       -2     
- Misses          984     987       +3     
- Partials        106     107       +1
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/codeborne/selenide/Configuration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...orne/selenide/webdriver/AbstractDriverFactory.java 70.45% <100%> (+1.4%) 11 <1> (+1) ⬆️
...e/selenide/impl/WebDriverThreadLocalContainer.java 78.98% <0%> (-2.9%) 29% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e30c6...559c6aa. Read the comment docs.

codecov-io commented Jan 4, 2018

Codecov Report

Merging #664 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #664      +/-   ##
===========================================
- Coverage     60.52%   60.4%   -0.12%     
+ Complexity      771     770       -1     
===========================================
  Files           148     148              
  Lines          2761    2763       +2     
  Branches        270     270              
===========================================
- Hits           1671    1669       -2     
- Misses          984     987       +3     
- Partials        106     107       +1
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/codeborne/selenide/Configuration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...orne/selenide/webdriver/AbstractDriverFactory.java 70.45% <100%> (+1.4%) 11 <1> (+1) ⬆️
...e/selenide/impl/WebDriverThreadLocalContainer.java 78.98% <0%> (-2.9%) 29% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e30c6...559c6aa. Read the comment docs.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 4, 2018

Coverage Status

Coverage decreased (-0.08%) to 64.278% when pulling 559c6aa on 556_config_capabilities into 62e30c6 on master.

coveralls commented Jan 4, 2018

Coverage Status

Coverage decreased (-0.08%) to 64.278% when pulling 559c6aa on 556_config_capabilities into 62e30c6 on master.

@SergeyPirogov

This comment has been minimized.

Show comment
Hide comment
@SergeyPirogov

SergeyPirogov Jan 5, 2018

Collaborator

@BorisOsipov looks good

Collaborator

SergeyPirogov commented Jan 5, 2018

@BorisOsipov looks good

@asolntsev asolntsev assigned asolntsev and BorisOsipov and unassigned asolntsev Jan 5, 2018

@asolntsev asolntsev added this to the 4.10 milestone Jan 5, 2018

@asolntsev asolntsev added the feature label Jan 5, 2018

@asolntsev asolntsev merged commit 77dac81 into master Jan 5, 2018

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.08%) to 64.278%
Details
codecov/patch 100% of diff hit (target 60.52%)
Details
codecov/project Absolute coverage decreased by -0.11% but relative coverage increased by +39.47% compared to 62e30c6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asolntsev asolntsev deleted the 556_config_capabilities branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment