Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#597 support non-breakable spaces in byText and withText #669

Merged
merged 1 commit into from Jan 7, 2018

Conversation

asolntsev
Copy link
Member

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@asolntsev asolntsev added this to the 4.10 milestone Jan 6, 2018
@asolntsev asolntsev self-assigned this Jan 6, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.517% when pulling bb88e29 on support-nonbreakable-space-in-xpath into 6a57da1 on master.

@codecov-io
Copy link

Codecov Report

Merging #669 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #669   +/-   ##
=========================================
  Coverage     60.62%   60.62%           
  Complexity      775      775           
=========================================
  Files           148      148           
  Lines          2776     2776           
  Branches        272      272           
=========================================
  Hits           1683     1683           
  Misses          985      985           
  Partials        108      108
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/codeborne/selenide/Selectors.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a57da1...bb88e29. Read the comment docs.

@asolntsev asolntsev merged commit ffdc23d into master Jan 7, 2018
@asolntsev asolntsev deleted the support-nonbreakable-space-in-xpath branch January 7, 2018 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants