New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#688 download files with cyrillic names #689

Merged
merged 6 commits into from Mar 12, 2018

Conversation

Projects
None yet
4 participants
@asolntsev
Contributor

asolntsev commented Feb 1, 2018

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@asolntsev asolntsev self-assigned this Feb 1, 2018

@asolntsev asolntsev added this to the 4.11 milestone Feb 1, 2018

@asolntsev asolntsev changed the title from #688 add test for reproducing the issue #688 to #688 download files with cyrillic names Mar 11, 2018

@asolntsev asolntsev requested a review from BorisOsipov Mar 11, 2018

@asolntsev asolntsev added the bug 🐛 label Mar 11, 2018

@asolntsev

This comment has been minimized.

Contributor

asolntsev commented Mar 11, 2018

@BorisOsipov Code review, please.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 11, 2018

Codecov Report

Merging #689 into master will increase coverage by 0.06%.
The diff coverage is 86.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #689      +/-   ##
============================================
+ Coverage      61.3%   61.37%   +0.06%     
  Complexity      802      802              
============================================
  Files           152      153       +1     
  Lines          2827     2832       +5     
  Branches        275      274       -1     
============================================
+ Hits           1733     1738       +5     
- Misses          987      988       +1     
+ Partials        107      106       -1
Impacted Files Coverage Δ Complexity Δ
...m/codeborne/selenide/proxy/FileDownloadFilter.java 94.82% <100%> (-0.42%) 18 <0> (-4)
...rne/selenide/impl/DownloadFileWithHttpRequest.java 80.28% <80%> (+0.55%) 13 <0> (-2) ⬇️
...n/java/com/codeborne/selenide/impl/HttpHelper.java 84.61% <84.61%> (ø) 6 <6> (?)
...e/selenide/impl/WebDriverThreadLocalContainer.java 81.61% <0%> (+0.73%) 30% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc725de...8d08ddd. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Mar 11, 2018

Coverage Status

Coverage increased (+0.03%) to 65.113% when pulling 8d08ddd on download-files-with-cyrillic-name into dc725de on master.

@BorisOsipov

This comment has been minimized.

Member

BorisOsipov commented Mar 11, 2018

LGTM 👍

@asolntsev asolntsev requested a review from vinogradoff Mar 11, 2018

@BorisOsipov BorisOsipov added the ready label Mar 12, 2018

@asolntsev asolntsev merged commit 51aef57 into master Mar 12, 2018

4 checks passed

codecov/patch 86.36% of diff hit (target 61.3%)
Details
codecov/project 61.37% (+0.06%) compared to dc725de
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 65.113%
Details

@asolntsev asolntsev deleted the download-files-with-cyrillic-name branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment