New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sandbox for chrome. #711

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
5 participants
@rosolko
Copy link
Collaborator

rosolko commented Apr 3, 2018

Proposed changes

This PR fix issue about not closing chrome instance on windows.
References:

If you want to restore such behavior manually pass --no-sandbox chrome option.

Feature build

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #711 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #711      +/-   ##
============================================
+ Coverage     61.82%   61.84%   +0.02%     
  Complexity      827      827              
============================================
  Files           154      154              
  Lines          2892     2891       -1     
  Branches        281      281              
============================================
  Hits           1788     1788              
  Misses          996      996              
+ Partials        108      107       -1
Impacted Files Coverage Δ Complexity Δ
...eborne/selenide/webdriver/ChromeDriverFactory.java 85.71% <ø> (-0.29%) 20 <0> (ø)
...e/selenide/impl/WebDriverThreadLocalContainer.java 82.35% <0%> (+0.73%) 30% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b13a158...eec0490. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 3, 2018

Coverage Status

Coverage decreased (-0.01%) to 65.548% when pulling eec0490 on rosolko:sandbox into b13a158 on codeborne:master.

@asolntsev asolntsev self-requested a review Apr 3, 2018

@asolntsev asolntsev self-assigned this Apr 3, 2018

@asolntsev asolntsev added this to the 4.11.1 milestone Apr 3, 2018

@asolntsev asolntsev merged commit df29ce6 into selenide:master Apr 3, 2018

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.01%) to 65.548%
Details
codecov/patch Coverage not affected when comparing b13a158...eec0490
Details
codecov/project 61.84% (+0.02%) compared to b13a158
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rosolko rosolko deleted the rosolko:sandbox branch Apr 3, 2018

@asolntsev

This comment has been minimized.

Copy link
Contributor

asolntsev commented Apr 3, 2018

@schipiga

This comment has been minimized.

Copy link

schipiga commented on eec0490 Apr 4, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment