New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #725 remote browser binary #726

Merged
merged 7 commits into from May 6, 2018

Conversation

Projects
None yet
5 participants
@vinogradoff
Member

vinogradoff commented May 4, 2018

Fix for using browserBinary on Remote Servers
extended logging

vinogradoff added some commits May 4, 2018

fixed #752 use of browserBinary for RemoteWebdriver
add info logging for usage of browserBinary
@BorisOsipov

See comments

@@ -52,6 +57,20 @@ DesiredCapabilities getDriverCapabilities(Proxy proxy) {
if (headless) {
capabilities.merge(getHeadlessCapabilities());
}
if (!browserBinary.isEmpty()) {
log.info("Using browser binary: " + browserBinary);

This comment has been minimized.

@BorisOsipov

BorisOsipov May 4, 2018

Member

Consider extract this block to separate method like for getHeadlessCapabilities()

class SafariDriverFactory extends AbstractDriverFactory {
private static final Logger log = Logger.getLogger(OperaDriverFactory.class.getName());

This comment has been minimized.

@BorisOsipov

BorisOsipov May 4, 2018

Member

OperaDriverFactory => SafariDriverFactory

@coveralls

This comment has been minimized.

coveralls commented May 4, 2018

Coverage Status

Coverage decreased (-0.4%) to 66.269% when pulling 89ac4fe on 725-remoteBrowserBinary into 9a87233 on master.

@codecov-io

This comment has been minimized.

codecov-io commented May 4, 2018

Codecov Report

Merging #726 into master will decrease coverage by 0.4%.
The diff coverage is 18.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #726      +/-   ##
============================================
- Coverage     63.36%   62.95%   -0.41%     
- Complexity      864      870       +6     
============================================
  Files           154      154              
  Lines          2989     3021      +32     
  Branches        291      297       +6     
============================================
+ Hits           1894     1902       +8     
- Misses          996     1019      +23     
- Partials         99      100       +1
Impacted Files Coverage Δ Complexity Δ
...borne/selenide/webdriver/FirefoxDriverFactory.java 79.41% <0%> (-2.41%) 9 <0> (ø)
...eborne/selenide/webdriver/ChromeDriverFactory.java 84% <0%> (-1.72%) 20 <0> (ø)
...eborne/selenide/webdriver/RemoteDriverFactory.java 50% <12.5%> (-18.75%) 12 <3> (+1)
...eborne/selenide/webdriver/SafariDriverFactory.java 37.5% <25%> (-12.5%) 3 <1> (+1)
...enide/webdriver/InternetExplorerDriverFactory.java 30% <25%> (-3.34%) 3 <1> (+1)
...odeborne/selenide/webdriver/EdgeDriverFactory.java 27.27% <25%> (-1.3%) 3 <1> (+1)
...deborne/selenide/webdriver/OperaDriverFactory.java 30% <50%> (+5%) 3 <1> (+1) ⬆️
...e/selenide/impl/WebDriverThreadLocalContainer.java 81.61% <0%> (+1.47%) 30% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a87233...89ac4fe. Read the comment docs.

@vinogradoff

This comment has been minimized.

Member

vinogradoff commented May 4, 2018

@BorisOsipov fixed

@rosolko rosolko added this to the 4.11.3 milestone May 6, 2018

@rosolko rosolko added the ready label May 6, 2018

@rosolko rosolko merged commit 8312d61 into master May 6, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@rosolko rosolko deleted the 725-remoteBrowserBinary branch May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment