Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cssValue condition. #727

Merged
merged 3 commits into from May 6, 2018

Conversation

Projects
None yet
5 participants
@rosolko
Copy link
Collaborator

rosolko commented May 4, 2018

Close #628 issue.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
Add cssValue condition.
Close #628 issue.

@rosolko rosolko requested review from asolntsev and BorisOsipov May 4, 2018

@rosolko rosolko self-assigned this May 4, 2018

@rosolko rosolko added this to the 4.11.3 milestone May 4, 2018

@rosolko rosolko added the feature label May 4, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 4, 2018

Coverage Status

Coverage decreased (-0.1%) to 66.745% when pulling 26d5bef on rosolko:cssValue into 8276676 on codeborne:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 4, 2018

Codecov Report

Merging #727 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #727      +/-   ##
============================================
- Coverage     63.56%   63.43%   -0.13%     
+ Complexity      866      865       -1     
============================================
  Files           154      154              
  Lines          2983     2989       +6     
  Branches        291      291              
============================================
  Hits           1896     1896              
- Misses          989      994       +5     
- Partials         98       99       +1
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/codeborne/selenide/Condition.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 81.61% <0%> (-0.74%) 30% <0%> (-1%)
...ava/com/codeborne/selenide/ElementsCollection.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../codeborne/selenide/impl/SelenideElementProxy.java 86.79% <0%> (+0.25%) 26% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8276676...26d5bef. Read the comment docs.

@vinogradoff

This comment has been minimized.

Copy link
Member

vinogradoff commented May 4, 2018

Could you please extend your integration test for one computed css property example?
means element doesn't have explicit "style" attribute, but the css property is set due to class/css rules etc.

Add cases with non exist and computed css values.
Extend javadoc.
Add proper toString for condition.
@rosolko

This comment has been minimized.

Copy link
Collaborator Author

rosolko commented May 6, 2018

@vinogradoff done.

@BorisOsipov BorisOsipov merged commit 974f0fa into selenide:master May 6, 2018

1 of 4 checks passed

codecov/patch 0% of diff hit (target 63.56%)
Details
codecov/project 63.43% (-0.13%) compared to 8276676
Details
coverage/coveralls Coverage decreased (-0.1%) to 66.745%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rosolko rosolko deleted the rosolko:cssValue branch May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.