New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicating screenshots on error #730

Merged
merged 1 commit into from May 5, 2018

Conversation

Projects
None yet
4 participants
@BorisOsipov
Member

BorisOsipov commented May 5, 2018

Fix for issue #729

Fix duplicating screenshots on error
Signed-off-by: Boris Osipov <osipov.boris@gmail.com>
@codecov-io

This comment has been minimized.

codecov-io commented May 5, 2018

Codecov Report

Merging #730 into master will decrease coverage by 0.1%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #730      +/-   ##
============================================
- Coverage     63.56%   63.45%   -0.11%     
+ Complexity      866      864       -2     
============================================
  Files           154      154              
  Lines          2983     2985       +2     
  Branches        291      291              
============================================
- Hits           1896     1894       -2     
- Misses          989      992       +3     
- Partials         98       99       +1
Impacted Files Coverage Δ Complexity Δ
...ava/com/codeborne/selenide/ElementsCollection.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../codeborne/selenide/impl/SelenideElementProxy.java 86.79% <100%> (+0.25%) 26 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 80.14% <0%> (-2.21%) 29% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8276676...0f9d124. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented May 5, 2018

Coverage Status

Coverage decreased (-0.08%) to 66.767% when pulling 0f9d124 on #729_fix_double_screenshots into 8276676 on master.

@BorisOsipov BorisOsipov requested a review from rosolko May 5, 2018

@rosolko

rosolko approved these changes May 5, 2018

@rosolko rosolko added this to the 4.11.3 milestone May 5, 2018

@rosolko rosolko merged commit 7e10aa5 into master May 5, 2018

1 of 4 checks passed

codecov/patch 50% of diff hit (target 63.56%)
Details
codecov/project 63.45% (-0.11%) compared to 8276676
Details
coverage/coveralls Coverage decreased (-0.08%) to 66.767%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rosolko rosolko deleted the #729_fix_double_screenshots branch May 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment