Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get browser mob proxy instance. #731

Merged
merged 1 commit into from May 7, 2018
Merged

Add ability to get browser mob proxy instance. #731

merged 1 commit into from May 7, 2018

Conversation

rosolko
Copy link
Collaborator

@rosolko rosolko commented May 7, 2018

  • Simplify and extend proxy test.
  • Exclude provided by webdrivermanager logback-classic module.
  • Use new testImplementation scope instead of old testCompile.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Simplify and extend proxy test.
Exclude provided by webdrivermanager logback-classic module.
Use new testImplementation scope instead old testCompile.
@rosolko rosolko added the feature label May 7, 2018
@rosolko rosolko added this to the 4.11.3 milestone May 7, 2018
@rosolko rosolko self-assigned this May 7, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 66.975% when pulling 607d160 on rosolko:openProxy into 35c26b6 on codeborne:master.

@codecov-io
Copy link

codecov-io commented May 7, 2018

Codecov Report

Merging #731 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #731      +/-   ##
===========================================
+ Coverage     63.65%   63.7%   +0.04%     
- Complexity      877     878       +1     
===========================================
  Files           154     154              
  Lines          3024    3025       +1     
  Branches        298     298              
===========================================
+ Hits           1925    1927       +2     
+ Misses         1000     999       -1     
  Partials         99      99
Impacted Files Coverage Δ Complexity Δ
.../codeborne/selenide/proxy/SelenideProxyServer.java 87.8% <100%> (+0.3%) 11 <1> (+1) ⬆️
...e/selenide/impl/WebDriverThreadLocalContainer.java 81.61% <0%> (+0.73%) 30% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c26b6...607d160. Read the comment docs.

@BorisOsipov BorisOsipov merged commit 352a6f6 into selenide:master May 7, 2018
@rosolko rosolko deleted the openProxy branch May 7, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants