Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '?' symbol to filename pattern to avoid url query string parameters. #735

merged 2 commits into from May 10, 2018
Changes from 1 commit
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

@@ -11,7 +11,7 @@

public class HttpHelper {

private final Pattern pattern = Pattern.compile(".*filename\\*?=\"?((.+)'')?([^\";]*)\"?(;charset=(.*))?.*", CASE_INSENSITIVE);
private final Pattern pattern = Pattern.compile(".*filename\\*?=\"?((.+)'')?([^\";?]*)\"?(;charset=(.*))?.*", CASE_INSENSITIVE);

public Optional<String> getFileNameFromContentDisposition(String headerName, String headerValue) {
if (!"Content-Disposition".equalsIgnoreCase(headerName) || headerValue == null) {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.