New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide webdrivermanager on api level. #736

Merged
merged 1 commit into from May 10, 2018

Conversation

Projects
None yet
4 participants
@rosolko
Collaborator

rosolko commented May 10, 2018

Proposed changes

If you create custom driver provider and want to download custom binary use provided dependency.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@rosolko rosolko added the feature label May 10, 2018

@rosolko rosolko added this to the 4.11.5 milestone May 10, 2018

@rosolko rosolko self-assigned this May 10, 2018

@rosolko rosolko requested a review from asolntsev May 10, 2018

@asolntsev

I am not sure why it's really useful.

If someone needs to configure WebdriverManager, he can also call WebdriverManager and create webdriver.

But the change is ok.

@codecov-io

This comment has been minimized.

codecov-io commented May 10, 2018

Codecov Report

Merging #736 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #736   +/-   ##
=========================================
  Coverage     63.61%   63.61%           
  Complexity      878      878           
=========================================
  Files           154      154           
  Lines          3029     3029           
  Branches        298      298           
=========================================
  Hits           1927     1927           
  Misses         1003     1003           
  Partials         99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e216b36...190f76d. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented May 10, 2018

Coverage Status

Coverage remained the same at 66.887% when pulling 190f76d on rosolko:open_wdm into e216b36 on codeborne:master.

@rosolko

This comment has been minimized.

Collaborator

rosolko commented May 10, 2018

@asolntsev Not from implementation level :)
Webdrivermanager for now marked in classpath as provided not compile and you can't just type WebDriverManager.chromedriver().setup(); that's the point.

@rosolko rosolko merged commit 0406aa3 into selenide:master May 10, 2018

4 checks passed

codecov/patch Coverage not affected when comparing e216b36...190f76d
Details
codecov/project 63.61% remains the same compared to e216b36
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 66.887%
Details

@rosolko rosolko deleted the rosolko:open_wdm branch May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment