Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread.getId() to log messages on closeWebDriver() method #737

merged 1 commit into from May 11, 2018


None yet
5 participants
Copy link

commented May 10, 2018

Update formatting

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.


  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

This comment has been minimized.

Copy link

commented May 10, 2018

Codecov Report

Merging #737 into master will decrease coverage by 0.04%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #737      +/-   ##
- Coverage     63.61%   63.57%   -0.05%     
  Complexity      878      878              
  Files           154      154              
  Lines          3029     3028       -1     
  Branches        298      298              
- Hits           1927     1925       -2     
- Misses         1003     1004       +1     
  Partials         99       99
Impacted Files Coverage Δ Complexity Δ
...e/selenide/impl/ 80.74% <28.57%> (-0.88%) 30 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e216b36...144e18f. Read the comment docs.


This comment has been minimized.

Copy link

commented May 10, 2018

Coverage Status

Coverage decreased (-0.04%) to 66.843% when pulling 144e18f on AlexanderPoleschuk:582 into e216b36 on codeborne:master.

@BorisOsipov BorisOsipov merged commit db3f74a into selenide:master May 11, 2018

1 of 4 checks passed

codecov/patch 28.57% of diff hit (target 63.61%)
codecov/project 63.57% (-0.05%) compared to e216b36
coverage/coveralls Coverage decreased (-0.04%) to 66.843%
continuous-integration/travis-ci/pr The Travis CI build passed

@rosolko rosolko added this to the 4.11.5 milestone May 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.