New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use selenium refresh for selenide refresh instead of reopen current url. #741

Merged
merged 1 commit into from May 17, 2018

Conversation

Projects
None yet
4 participants
@rosolko
Collaborator

rosolko commented May 17, 2018

Proposed changes

Use selenium refresh for selenide refresh instead of reopen current url.
Fix #740 issue.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@rosolko rosolko added the bug 🐛 label May 17, 2018

@rosolko rosolko added this to the 4.11.5 milestone May 17, 2018

@rosolko rosolko self-assigned this May 17, 2018

@rosolko rosolko requested review from asolntsev and BorisOsipov May 17, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 17, 2018

Codecov Report

Merging #741 into master will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #741      +/-   ##
============================================
- Coverage     63.57%   63.49%   -0.08%     
+ Complexity      878      877       -1     
============================================
  Files           154      154              
  Lines          3028     3030       +2     
  Branches        298      298              
============================================
- Hits           1925     1924       -1     
- Misses         1004     1007       +3     
  Partials         99       99
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/codeborne/selenide/Selenide.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/com/codeborne/selenide/impl/Navigator.java 66.66% <100%> (-2.19%) 21 <1> (ø)
...e/selenide/impl/WebDriverThreadLocalContainer.java 80% <0%> (-0.75%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778e4ff...8c7f5b2. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented May 17, 2018

Coverage Status

Coverage decreased (-0.08%) to 66.766% when pulling 8c7f5b2 on rosolko:refresh into 778e4ff on codeborne:master.

@BorisOsipov BorisOsipov merged commit ad4557c into selenide:master May 17, 2018

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.08%) to 66.766%
Details
codecov/patch 66.66% of diff hit (target 63.57%)
Details
codecov/project Absolute coverage decreased by -0.07% but relative coverage increased by +3.09% compared to 778e4ff
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rosolko rosolko deleted the rosolko:refresh branch May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment