New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend isHeadless method with configuration value. Fix #750 issue. #751

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
4 participants
@rosolko
Collaborator

rosolko commented May 29, 2018

Fix #750 issue.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@rosolko rosolko added the bug 🐛 label May 29, 2018

@rosolko rosolko added this to the 4.12.0 milestone May 29, 2018

@rosolko rosolko self-assigned this May 29, 2018

@rosolko rosolko requested review from asolntsev and BorisOsipov May 29, 2018

@codecov-io

This comment has been minimized.

codecov-io commented May 29, 2018

Codecov Report

Merging #751 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #751     +/-   ##
===========================================
- Coverage     63.66%   63.56%   -0.1%     
+ Complexity      879      878      -1     
===========================================
  Files           154      154             
  Lines          3030     3030             
  Branches        298      298             
===========================================
- Hits           1929     1926      -3     
- Misses         1003     1005      +2     
- Partials         98       99      +1
Impacted Files Coverage Δ Complexity Δ
...n/java/com/codeborne/selenide/WebDriverRunner.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 81.48% <0%> (-2.23%) 30% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab64b3b...ecaa148. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented May 29, 2018

Coverage Status

Coverage decreased (-0.07%) to 66.832% when pulling ecaa148 on rosolko:fix-headless into ab64b3b on codeborne:master.

@BorisOsipov BorisOsipov merged commit f148c9c into selenide:master May 29, 2018

1 of 4 checks passed

codecov/patch 0% of diff hit (target 63.66%)
Details
codecov/project 63.56% (-0.1%) compared to ab64b3b
Details
coverage/coveralls Coverage decreased (-0.07%) to 66.832%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rosolko rosolko deleted the rosolko:fix-headless branch May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment