New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final fix for issue #734 #768

Merged
merged 3 commits into from Jul 26, 2018

Conversation

Projects
None yet
2 participants
@rosolko
Copy link
Collaborator

rosolko commented Jul 25, 2018

Proposed changes

Fix #734 issue.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works

@rosolko rosolko added the bug 🐛 label Jul 25, 2018

@rosolko rosolko self-assigned this Jul 25, 2018

@rosolko rosolko requested review from asolntsev and BorisOsipov Jul 25, 2018

@asolntsev asolntsev added this to the 4.12.4 milestone Jul 26, 2018

@asolntsev asolntsev merged commit 569c9a5 into selenide:master Jul 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rosolko rosolko deleted the rosolko:issue_734 branch Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment