New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented method for retrieving the last child element of a given element #771

Merged
merged 3 commits into from Jul 30, 2018

Conversation

Projects
None yet
4 participants
@symonk
Copy link
Contributor

symonk commented Jul 29, 2018

Opening this PR as a means to get feedback on an attempt at implementing some of the functionality outlined in #429, if it is a suitable approach I will continue implementing some other useful capabilities around element relationships. Thank you

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@vinogradoff
Copy link
Member

vinogradoff left a comment

Could you please just convert from assertThat to elementShould.

assertThat() neither waits (for async loading) nor gather diagnsostic informations for fails (screenshots/source code). should* methods do.

@vinogradoff

This comment has been minimized.

Copy link
Member

vinogradoff commented Jul 30, 2018

I like this PR, I would merge it as soon as integration tests are fixed. @rosolko @BorisOsipov @asolntsev

@BorisOsipov

This comment has been minimized.

Copy link
Member

BorisOsipov commented Jul 30, 2018

@symonk thank you for getting this done! Awesome 👍
About

I will continue implementing some other useful capabilities around element relationships

We are not sure that other capabilities around element relationships is useful for Selenide and we are going to close as done #429 after merging this.

@symonk

This comment has been minimized.

Copy link
Contributor

symonk commented Jul 30, 2018

ok, I will focus my time on open issue(s) and other help-wanted issue(s) instead. Is there somewhere to have visibility of feature implementations that are a high priority? or outstanding work that must be done for the next release? @BorisOsipov

@rosolko rosolko added the feature label Jul 30, 2018

@rosolko rosolko added this to the 4.12.4 milestone Jul 30, 2018

@rosolko rosolko merged commit 20eb860 into selenide:master Jul 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@symonk symonk deleted the symonk:last-child branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment