New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firefox tests #778

merged 12 commits into from Aug 16, 2018


None yet
1 participant
Copy link

asolntsev commented Aug 15, 2018

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.


  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

asolntsev added some commits Aug 8, 2018

fix some of FireFox tests
they have been ignore for a long time :(
do not require Javadoc for every public method
* it forces people to write useless comments
* good code should be clear enough without javadoc. Good class/method names are much more important than comments.
return at least HTML file if failed to take screenshot
for example, it's good for htmlunit driver

@asolntsev asolntsev self-assigned this Aug 15, 2018

@asolntsev asolntsev added this to the 4.12.4 milestone Aug 15, 2018

asolntsev added some commits Aug 16, 2018

avoid depending on browser specific. Exclude all requests to Mozilla/…
…Chrome/... sites that browsers to by their initiative

@asolntsev asolntsev merged commit 046c4d2 into master Aug 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@asolntsev asolntsev deleted the fix-firefox-tests branch Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment