New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading error message $.selectOptionByValue() reports #780

Merged
merged 2 commits into from Aug 17, 2018

Conversation

Projects
None yet
2 participants
@tsukakei
Copy link
Contributor

tsukakei commented Aug 17, 2018

Proposed changes

Hi, Selenium maintainers!

As @asolntsev described in #709, $.selectOptionByValue() reports a misleading error message.
So I fixed selectOptionByValue referring to selectOptionByTextOrIndex and selectOptionContainingText.

This PR is related to #709 .

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@asolntsev asolntsev self-requested a review Aug 17, 2018

@asolntsev asolntsev self-assigned this Aug 17, 2018

@asolntsev asolntsev added this to the 4.12.4 milestone Aug 17, 2018

@asolntsev asolntsev merged commit 4fa9c72 into selenide:master Aug 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asolntsev

This comment has been minimized.

Copy link
Contributor

asolntsev commented Aug 17, 2018

@tsukakei Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment