New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#601 add collection checks with custom timeout #781

Merged
merged 1 commit into from Aug 19, 2018

Conversation

Projects
None yet
3 participants
@asolntsev
Copy link
Contributor

asolntsev commented Aug 18, 2018

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@asolntsev asolntsev self-assigned this Aug 18, 2018

@asolntsev asolntsev requested a review from BorisOsipov Aug 18, 2018

@asolntsev asolntsev added the feature label Aug 18, 2018

@asolntsev asolntsev added this to the 4.12.4 milestone Aug 18, 2018

@asolntsev asolntsev requested review from vinogradoff and rosolko Aug 19, 2018

@BorisOsipov

This comment has been minimized.

Copy link
Member

BorisOsipov commented Aug 19, 2018

Awesome 👍

@rosolko
Copy link
Collaborator

rosolko left a comment

Looks good

@asolntsev asolntsev merged commit cb5dcee into master Aug 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@asolntsev asolntsev deleted the custom-timeout-for-collection-methods branch Aug 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment