Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #784 and close #785 #787

Merged
merged 8 commits into from Aug 27, 2018

Conversation

Projects
None yet
2 participants
@asolntsev
Copy link
Contributor

asolntsev commented Aug 26, 2018

Proposed changes

Fix #784 and close #785

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@asolntsev asolntsev self-assigned this Aug 26, 2018

@asolntsev asolntsev force-pushed the rosolko-784 branch from dd03bd1 to 1fa0ba0 Aug 27, 2018

@rosolko rosolko self-requested a review Aug 27, 2018

@rosolko
Copy link
Collaborator

rosolko left a comment

Looks good

@rosolko rosolko changed the title Rosolko 784 Fix #784 and close #785 Aug 27, 2018

@asolntsev asolntsev merged commit 2a928a0 into master Aug 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@asolntsev asolntsev deleted the rosolko-784 branch Aug 27, 2018

@asolntsev asolntsev added this to the 4.14.0 milestone Aug 27, 2018

@asolntsev asolntsev referenced this pull request Aug 27, 2018

Closed

Fix #784 Enable BasicAuth through Selenide proxy server #785

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.