New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration cleanup and refactoring. #812

Merged
merged 4 commits into from Sep 26, 2018

Conversation

Projects
None yet
4 participants
@rosolko
Copy link
Collaborator

rosolko commented Sep 25, 2018

Set chrome as default browser and close #811.
Do not maximize browser by default and close #810.
Set default browser size to 1366x768.
Style all configuration with camelCase format.
Remove deprecate from internet explorer IE alias related on feedback from #806.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
Set chrome as default browser and close #811.
Do not maximize browser by default and close #810.
Set default browser size to 1024x768.
Set default browser position to 30x30.
Style all configuration with camelCase format.
Remove deprecate from internet explorer IE alias.

@rosolko rosolko requested review from asolntsev and BorisOsipov Sep 25, 2018

@rosolko rosolko self-assigned this Sep 25, 2018

@rosolko rosolko added this to the 5.0.0 milestone Sep 25, 2018

private String browserPosition = System.getProperty("selenide.browserPosition");
private boolean startMaximized = Boolean.parseBoolean(System.getProperty("selenide.startMaximized",
System.getProperty("selenide.start-maximized", "true")));
private String browserSize = System.getProperty("selenide.browserSize", "1024x768");

This comment has been minimized.

@BorisOsipov

BorisOsipov Sep 25, 2018

Member

maybe 1366x768 default will be better?
See statistics https://www.w3schools.com/browsers/browsers_display.asp

This comment has been minimized.

@rosolko

rosolko Sep 25, 2018

Collaborator

This value based on note from #810:

I recommend to set browser window size explicitly by using Configuration.browserSize=1024x768 (a minimal browser size that your application should support).

This comment has been minimized.

@BorisOsipov

BorisOsipov Sep 25, 2018

Member

yep I got it. But I think 1024x768 is legacy screen resolution

This comment has been minimized.

@asolntsev

asolntsev Sep 26, 2018

Contributor

Yes, I put 1024x768 without any reason. Just some memories from my childhood. :)

private boolean headless = Boolean.parseBoolean(System.getProperty("selenide.headless", "false"));
private String remote = System.getProperty("selenide.remote", System.getProperty("remote"));
private String remote = System.getProperty("selenide.remote");
private String browserSize = System.getProperty("selenide.browserSize", "1024x768");
private String browserVersion = System.getProperty("selenide.browserVersion");
private String browserPosition = System.getProperty("selenide.browserPosition", "30x30");

This comment has been minimized.

@asolntsev

asolntsev Sep 26, 2018

Contributor

I am not sure setting 30x30 is a good idea. Because moving the browser takes time. It will make many tests slower.
And it was never needed - at least in my projects.

Set default browser size to 1366x768.
Remove default browser position.
Add ability to maximize browser on start.

@rosolko rosolko merged commit c8a60d1 into selenide:master Sep 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rosolko rosolko deleted the rosolko:cleanup branch Sep 26, 2018

private boolean captureJavascriptErrors = Boolean.parseBoolean(System.getProperty("selenide.captureJavascriptErrors", "true"));
private boolean screenshots = Boolean.parseBoolean(System.getProperty("selenide.screenshots", "true"));

private boolean savePageSource = Boolean.parseBoolean(System.getProperty("selenide.savePageSource", "true"));
private String reportsFolder = System.getProperty("selenide.reportsFolder",
System.getProperty("selenide.reports", "build/reports/tests"));

This comment has been minimized.

@darklynx

darklynx Dec 19, 2018

Since you have dropped the support for selenide.reports system variable in favor of selenide.reportsFolder, you should probably update the official documentation: https://selenide.org/documentation/screenshots.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment