New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for webdrivermanager #825

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@asolntsev
Copy link
Contributor

asolntsev commented Oct 1, 2018

Proposed changes

Let's store in a file ~/.m2/repository/webdriver/webdriver.gecko.driver.mac64.timestamp the timestamp when WDM checked for updates last time.

It will allows us to avoid WDM calling github too often thus getting "403 error" too often.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

asolntsev added some commits Oct 1, 2018

#825 Add workaround for WebDriverManager issue
... when it calls github too often and gets 403 error

@asolntsev asolntsev requested a review from rosolko Oct 1, 2018

@asolntsev asolntsev added this to the 5.0.0-rc.2 milestone Oct 1, 2018

@@ -58,20 +62,35 @@ private void setupFirefox() {

private void cacheMeIfYouCan(String systemPropertyName, Runnable webdriverSetup) {
if (webdriverIsAlreadyInitialized(systemPropertyName)) {
log.info("Skip: webdriver is already initialized: " + System.getProperty(systemPropertyName));

This comment has been minimized.

@rosolko

rosolko Oct 2, 2018

Collaborator

Do we really need it on info level?
I think debug will be enough.

This comment has been minimized.

@asolntsev

asolntsev Oct 2, 2018

Contributor

I planned to delete this commit in future. It's temporary needed to debug the problem.

@rosolko

rosolko approved these changes Oct 2, 2018

Copy link
Collaborator

rosolko left a comment

LGMT

@asolntsev asolntsev merged commit 8583ca4 into master Oct 2, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@asolntsev asolntsev deleted the workaround-for-webdrivermanager branch Oct 2, 2018

asolntsev added a commit that referenced this pull request Oct 3, 2018

asolntsev added a commit that referenced this pull request Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment