Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for `open("about:blank")` #915

Merged
merged 2 commits into from May 3, 2019

Conversation

Projects
None yet
3 participants
@asolntsev
Copy link
Contributor

commented Feb 27, 2019

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@rosolko

rosolko approved these changes Mar 2, 2019

@symonk

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

tagging #914

@rosolko rosolko added this to the 5.3.0 milestone Apr 3, 2019

@rosolko rosolko changed the title add support for `open("about:blank")` Add support for `open("about:blank")` May 3, 2019

@rosolko rosolko merged commit 672254d into master May 3, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@rosolko rosolko deleted the support-blank-window branch May 3, 2019

@asolntsev asolntsev modified the milestones: 5.3.0, 5.2.3 May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.