This repository has been archived by the owner. It is now read-only.

Improve error message when attempting to open a test case with no commands #1010

Open
lukeis opened this Issue Mar 2, 2016 · 9 comments

Comments

Projects
None yet
1 participant
@lukeis
Copy link
Member

lukeis commented Mar 2, 2016

Originally reported on Google Code with ID 1010

What steps will reproduce the problem?

1. Attempt to open a test case with no commands - for example a previously saved test
suite file instead of a test case file.

What is the expected output? What do you see instead?

Expected: A message informing that the test case contains no commands. If we can detect
that the file is a test suite file maybe provide the user the option to open the suite
instead.

Actual: The message 'error loading test case: no command found'

What version of the product are you using? On what operating system?

Selenium IDE 1.0.8
OS: Any

Reported by dave.hunt on 2010-11-17 17:13:34

@lukeis

This comment has been minimized.

Copy link
Member Author

lukeis commented Mar 2, 2016

Hi,

This used to bug me too! The attached patch will silently open it as a suite :-) 

Cheers,
Samit

Reported by Samit.Badle on 2010-11-17 19:07:20


- _Attachment: [patch.txt](https://storage.googleapis.com/google-code-attachments/selenium/issue-1010/comment-1/patch.txt)_
@lukeis

This comment has been minimized.

Copy link
Member Author

lukeis commented Mar 2, 2016

in trunk; or bamboo

Reported by adamgoucher on 2010-11-17 19:26:09

  • Status changed: Fixed
@lukeis

This comment has been minimized.

Copy link
Member Author

lukeis commented Mar 2, 2016

This doesn't entirely solve the issue raised. The error message when loading an empty
test case is still 'error loading test case: no command found'. Did we not want to
make it more user friendly? Something like 'The file you have selected does not contain
any commands. Please try another file.'

Also, although I like the idea of being able to detect that the file is a test suite
and open it I think the user should be informed that's what we're doing for them. Otherwise
there's no need for the Open Test Suite menu item...

Something like 'The file you have selected is a test suite. Would you like to open
it?'. I'm not sure about the wording, but hopefully you get my point.

Reported by dave.hunt on 2010-11-17 19:43:56

  • Status changed: Accepted
@lukeis

This comment has been minimized.

Copy link
Member Author

lukeis commented Mar 2, 2016

Hi,

I agree it does not solve the issue completely, but I think it is a good improvement.
Is there any reason to have the Open test suite menu item? I have often tried to open
the test suite as a test case. I think there should be one Open to Rule them all, er,
I mean open them all. So, I suggest, getting rid of the menu item altogether and while
we are there, perhaps investigate the usablity of the entire menu structure. While
it works, I keep getting the feeling that it can be polished a bit.

For the first: How does this message sound? 'The file you have selected does not contain
any commands. Please try again later.' -- Just kidding :-) 'Selenium IDE was not able
to find any commands in the selected file. Would you like to proceed with an empty
test case? OK/Cancel' If the user selects cancel, then we cancel the operation otherwise
accept the empty one.

As an aside, how did you still get this error message on IDE 1.0.8? Try saving an empty
test case and try opening it again in 1.0.8.

Cheers,
Samit

Reported by Samit.Badle on 2010-11-17 22:57:10

@lukeis

This comment has been minimized.

Copy link
Member Author

lukeis commented Mar 2, 2016

As I was applying this patch I was thinking the same thing. But next week...

Reported by adamgoucher on 2010-11-18 00:56:56

@lukeis

This comment has been minimized.

Copy link
Member Author

lukeis commented Mar 2, 2016

Open test suite menu removed in this patch. Did not modify the message yet as I still
want to know how you reproduced it.

Cheers,
Samit

Reported by Samit.Badle on 2010-11-18 14:02:37


- _Attachment: [patch.removesuiteopenmenu.txt](https://storage.googleapis.com/google-code-attachments/selenium/issue-1010/comment-6/patch.removesuiteopenmenu.txt)_
@lukeis

This comment has been minimized.

Copy link
Member Author

lukeis commented Mar 2, 2016

Reported by jari.bakken on 2011-04-22 10:07:30

  • Labels added: Component-IDE
  • Labels removed: ide
@lukeis

This comment has been minimized.

Copy link
Member Author

lukeis commented Mar 2, 2016

I have the same problem encountered upon opening my Test Suite under File > Open. Same
with File > Open Test Suite. 

"error loading test case: no command found"

Selenium IDE 2.5.0
Browser: Firefox 31.0
OS: Window XP

By the way, I am newbie using this automation tool. Any feedback on this matter is
highly appreciated. Thank you. 

Reported by cris.nasayao on 2014-08-13 10:33:37


- _Attachment: [TS_Login.html](https://storage.googleapis.com/google-code-attachments/selenium/issue-1010/comment-8/TS_Login.html)_
@lukeis

This comment has been minimized.

Copy link
Member Author

lukeis commented Mar 2, 2016

Reported by luke.semerau on 2015-09-17 17:44:23

  • Labels added: Restrict-AddIssueComment-Commit

@SeleniumHQ SeleniumHQ locked and limited conversation to collaborators Mar 4, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.