Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

selenium ide problem that "clickAndWait" becomes "click". #419

Closed
lukeis opened this issue Mar 2, 2016 · 10 comments
Closed

selenium ide problem that "clickAndWait" becomes "click". #419

lukeis opened this issue Mar 2, 2016 · 10 comments

Comments

@lukeis
Copy link
Member

lukeis commented Mar 2, 2016

Originally reported on Google Code with ID 419

There is a problem that "clickAndWait" becomes "click" in selenium ide. 

This bug occurs when the event record of selenium ide is stopped, and it
adds and the line is deleted

Reproduction Steps:
1.Please select full powers by Ctrl + A while recording with selenium ide
and delete all the tests with Delete. 
2.And, when a new event is recorded, it can be confirmed that the button
click is not "clickAndWait" but "click". 

Fix:
editor.js Editor.prototype.addCommand function 
    } else {
//        this.lastCommandIndex = this.view.getRecordIndex();          //bug!!
          this.lastCommandIndex = this.getTestCase().commands.length;  //fix

        this.getTestCase().commands.splice(this.lastCommandIndex, 0, command);
        this.view.rowInserted(this.lastCommandIndex);
        this.timeoutID = setTimeout("editor.clearLastCommand()", 300);
    }

It is repaired for the time being by this. 
Repaired in selenium ide version 1.0.4 and 1.0.2  is confirmed. 

A detailed explanation is in the blog of me Japanese. 
http://d.hatena.ne.jp/rti7743/20090929/1254237759

Reported by super.rti on 2010-03-10 20:11:47


- _Attachment: [editor.js.patch](https://storage.googleapis.com/google-code-attachments/selenium/issue-419/comment-0/editor.js.patch)_
@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

Reported by jmleyba on 2010-04-11 18:26:01

  • Labels added: ide

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

This bug seems to have been around for quite a while:

http://jira.openqa.org/browse/SIDE-197

Thanks for the fix. This one is quite important to me. Any word on when we can expect
an updated Firefox plugin with this fix included?

Reported by jacksenechal on 2010-05-02 23:45:17

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

Thank you for the comment. 

>This bug seems to have been around for quite a while:
>http://jira.openqa.org/browse/SIDE-197

It looks like the problem. 
My patch corrects it. 

I do not think the patch to be taken still. 

Reported by super.rti on 2010-05-03 01:15:44

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

Hi,

thank you for the patch, I fixed the bug as you suggested. @super.rti: Could you
please "sign" the contributor license agreement at: 
http://code.google.com/legal/individual-cla-v1.0.html

Reported by jeremy.herault on 2010-06-05 15:03:52

  • Status changed: Fixed

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

Thank you for the Comit!!

>Could you please "sign" the contributor license agreement at: 
I signed a license.

Reported by super.rti on 2010-06-06 07:09:34

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

Reported by jeremy.herault on 2010-06-08 07:39:56

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

Reverted in r10536 as it conflicts with Issue 968 as recording in the middle of the
script is more common scenario. Another solution needs to be found. 
 - Samit

Reported by Samit.Badle on 2010-12-06 21:03:27

  • Status changed: Accepted

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

Fixed with another solution in r10537. Let me know if you are still facing any issues
with this.
- Samit

Reported by Samit.Badle on 2010-12-07 09:38:11

  • Status changed: Fixed

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

I do not have any problem in this revision (r10537).
I confirmed that the problem of click was revised.

Thanks for the fix.

Reported by super.rti on 2010-12-07 17:57:32

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

Reported by luke.semerau on 2015-09-17 17:48:57

  • Labels added: Restrict-AddIssueComment-Commit

@lukeis lukeis closed this as completed Mar 2, 2016
@SeleniumHQ SeleniumHQ locked and limited conversation to collaborators Mar 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant