Firefox 35: Passing arguments to executeScript isn't working

[lukeis]

Originally reported on Google Code with ID 8390

With Firefox 35, passing arguments to executeScript is not working like it used to:

Expected behaviour:

>> d.execute_script("return typeof arguments[0]", "foo")
=> "string"

Actual behaviour

>> d.execute_script("return typeof arguments[0]", "foo")
=> "undefined"

Reported by jari.bakken on 2015-01-15 13:57:18

[lukeis]

Console warning:

Security wrapper denied access to property length on privileged Javascript object.
Support for exposing privileged objects to untrusted content via __exposedProps__ is
being gradually removed - use WebIDL bindings or Components.utils.cloneInto instead.
Note that only the first denied property access from a given global object will be
reported.

Reported by jari.bakken on 2015-01-15 14:14:29

[lukeis]

I don't have time to dig into this further right now, but here's what I've found so
far:

The warning message suggests we use Components.utils.cloneInto with a Sandbox. Currently
we only use a sandbox if the document is in designMode, and then async script execution
is "not supported". 

Marionette appears to implement executeAsyncScript with a Sandbox, so it's likely possible.

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-listener.js?from=marionette-listener.js&case=true#528

We could ignore executeAsyncScript for now and just force the sandbox code path for
Firefox 35, i.e.:

  https://gist.github.com/jarib/6a19bd42d2f90c9055b3

However this breaks a few tests: we're no longer able to call functions that are already
defined on the page through executeScript.

Reported by jari.bakken on 2015-01-15 15:13:11

[lukeis]

Reported by jari.bakken on 2015-01-15 15:13:50

[lukeis]

I can replicate this behaviour on OSX 10. 9.5 and Ubuntu using the selenium-webdriver
gem (2.44.0) and Firefox 35.0. Reverting firefox to 34.0 as downloaded from https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/34.0/mac/en-US/
resolves the issue.

The issue is trigged with calls to Capybara::Selenium::Node#set on an <input> field

Reported by chris.atkins@lonelyplanet.com.au on 2015-01-16 02:46:12

[lukeis]

Issue 8389 has been merged into this issue.

Reported by jmleyba on 2015-01-16 03:26:00

[lukeis]

Issue 8398 has been merged into this issue.

Reported by jmleyba on 2015-01-16 20:16:16

[lukeis]

Issue 8387 has been merged into this issue.

Reported by jmleyba on 2015-01-16 20:17:06