[js] minor tweaks to silence more type warnings

SeleniumHQ · Mar 11, 2016 · 981cb1a · 981cb1a
1 parent 0b9d599
commit 981cb1a
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 2 deletions.
diff --git a/javascript/node/externs/global.js b/javascript/node/externs/global.js
@@ -22,6 +22,29 @@
 /** @const */
 var global = this;
 
+// DOM type references. Dossier removes DOM externs when type-checking Node
+// modules.
+
+/** @constructor */
+function Document() {};
+/**
+ * @param {string} tagName .
+ * @return {!Element} .
+ */
+Document.prototype.createElement = function(tagName) {};
+
+/** @constructor */
+function Element() {}
+
+/** @type {!Document} */Element.prototype.ownerDocument;
+/** @type {string} */Element.prototype.innerHTML;
+/** @type {string} */Element.prototype.outerHTML;
+/** @param {!Element} child . */
+Element.prototype.appendChild = function(child) {};
+/** @param {boolean} deep . */
+Element.prototype.cloneNode = function(deep) {};
+
+
 // The following will only actually be defined if running with mocha.
 
 /**

diff --git a/javascript/node/selenium-webdriver/lib/webdriver.js b/javascript/node/selenium-webdriver/lib/webdriver.js
@@ -2135,7 +2135,7 @@ class WebElement {
    */
   getOuterHtml() {
     return this.driver_.executeScript(function() {
-      var element = arguments[0];
+      var element = /** @type {!Element} */(arguments[0]);
       if ('outerHTML' in element) {
         return element.outerHTML;
       } else {

diff --git a/javascript/node/selenium-webdriver/test/execute_script_test.js b/javascript/node/selenium-webdriver/test/execute_script_test.js
@@ -308,8 +308,22 @@ test.suite(function(env) {
       });
     });
 
-  });
+    describe('getInnerHtml', function() {
+      test.it('returns element innerHTML using executeScript', function() {
+        let html = driver.findElement(By.css('div.request')).getInnerHtml();
+        assert(html).equalTo('GET /common/echo HTTP/1.1');
+      });
+    });
 
+    describe('getOuterHtml', function() {
+      test.it('returns element outerHTML using executeScript', function() {
+        let html = driver.findElement(By.css('div.request')).getOuterHtml();
+        assert(html)
+            .equalTo('<div class="request">GET /common/echo HTTP/1.1</div>');
+      });
+    });
+  });
+
   function verifyJson(expected) {
     return function(actual) {
       assert(JSON.stringify(actual)).equalTo(JSON.stringify(expected));