Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link on "Semitic" page is broken #447

Closed
frogsquire opened this issue Dec 10, 2021 · 4 comments · Fixed by #448
Closed

Link on "Semitic" page is broken #447

frogsquire opened this issue Dec 10, 2021 · 4 comments · Fixed by #448
Labels
Language · en_EN English definitions Status · In Progress Type · Bug Something isn't working Type · Definitions Relates to specific definitions Type · Writing For definitions and/or documentation

Comments

@frogsquire
Copy link

frogsquire commented Dec 10, 2021

The link on this page:

https://www.selfdefined.app/definitions/semitic/

(under "related terms" it is the only link)

which should go to

https://www.selfdefined.app/definitions/antisemitism/

instead goes to

https://www.selfdefined.app/definitions/antisemitic

@ovlb ovlb added Type · Bug Something isn't working Type · Writing For definitions and/or documentation Type · Definitions Relates to specific definitions Language · en_EN English definitions labels Dec 11, 2021
@ovlb
Copy link
Collaborator

ovlb commented Dec 11, 2021

Thanks for bringing this to our attention.

Pinging @tatianamac on this. I guess it would make sense to change it to the existing antisemitism page as it’s probably unlikely that we’ll have a separate page for antisemitic in the future?

@tatianamac
Copy link
Collaborator

@frogsquire Thanks for the issue and ping @ovlb ! Opened a fix.

@frogsquire
Copy link
Author

frogsquire commented Dec 22, 2021

Thank you! At a future point, it might be good to have a discussion about the contents of the antisemitism page itself; specifically, while the point that Jews are not an Ashkenazi/white monolith is important, the idea of Jews as a "global race" has been co-opted by antisemites and it's important to distinguish the truth from those skewed views.

But that's beyond the scope of this issue, if/when I have time to think on the wording, I will open another ticket.

@tatianamac
Copy link
Collaborator

Thank you! At a future point, it might be good to have a discussion about the contents of the antisemitism page itself; specifically, while the point that Jews are not an Ashkenazi/white monolith is important, the idea of Jews as a "global race" has been co-opted by antisemites and it's important to distinguish the truth from those skewed views.

But that's beyond the scope of this issue, if/when I have time to think on the wording, I will open another ticket.

@frogsquire Thanks for opening this issue. I'll look forward to seeing your new ticket around the globalisation piece! Happy rest of the year. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language · en_EN English definitions Status · In Progress Type · Bug Something isn't working Type · Definitions Relates to specific definitions Type · Writing For definitions and/or documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants