default to not storing keystrokes by default #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
approved these changes
Sep 7, 2017
selfspy/__init__.py
Outdated
| this is similar to 'store_true' or 'store_false', but allows | ||
| arguments prefixed with --no to disable the default. the default | ||
| is set depending on the first argument - if it starts with the | ||
| negative form (define by default as '--no'), the default is False, |
we should safe defaults. by default, this acts as a keylogger which means it will store every key, every password ever typed. this is a huge security risk and people should deliberately make that choice when they run the software.
anarcat
force-pushed
the
no-text-default
branch
from
cbbb1f2
to
addb045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should safe defaults. by default, this acts as a keylogger which
means it will store every key, every password ever typed. this is a
huge security risk and people should deliberately make that choice
when they run the software.