fix Play Store upload: pin httplib2 to escape 0.20.4 redirect bug#2145
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR migrates Python dependency installation for Play Store uploads from an inline ChangesPlay Store Deployment Dependencies
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes a Play Store AAB upload failure caused by the GitHub runner shipping
Confidence Score: 3/5The workflow change itself is sound, but two of the pinned package versions in the new requirements file appear not to exist on PyPI, which will cause the Android deploy job to fail at the install step. The requirements file pins google-auth-httplib2==0.4.0 and google-api-python-client==2.197.0, and web searches against PyPI confirm the highest published versions are 0.3.1 and 2.196.0 respectively. A pip install against either of those exact pins will error out, meaning the intended fix for the AAB upload regression would never reach the upload step. app/scripts/requirements-play-store.txt — the two version pins that don't resolve need to be corrected before this can land. Important Files Changed
|
Summary
Redirected but the response is missing a Location: header.>=0.19.0floor so pip never replaced it. httplib2 0.20.x has a resumable-upload redirect regression that breaks the resumable session init for the AAB upload.httplib2==0.31.2) and installs them with--upgradeso the fixed version overrides the pre-installed one. Exact pins also make the deploy reproducible, so a future upstream release can't silently break it again.Changes
Config/infra
app/scripts/requirements-play-store.txtpinning theupload_to_play_store.pydeps:httplib2==0.31.2,google-auth==2.53.0,google-auth-oauthlib==1.4.0,google-auth-httplib2==0.4.0,google-api-python-client==2.197.0..github/workflows/mobile-deploy.yml: install step now runspython -m pip install --upgrade -r .../requirements-play-store.txt(same interpreter that runs the upload, forces replacement of system httplib2), plus a verification line that prints the resolvedhttplib2.__version__/__file__so the CI log proves it escaped/usr/lib/python3/dist-packages.Test Plan
httplib2 0.31.2 …(not…/dist-packages/… 0.20.4)📶 … % uploadedand completespip install -r app/scripts/requirements-play-store.txtresolves cleanly (verified locally in a clean venv: exit 0)🤖 Generated with Claude Code
Summary by CodeRabbit