Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't adjust NVA tunneled bases #10

Closed
richardmtl opened this issue Feb 12, 2023 · 4 comments
Closed

Can't adjust NVA tunneled bases #10

richardmtl opened this issue Feb 12, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@richardmtl
Copy link
Collaborator

I imagine this won't come up very often, but I wanted to Infiltrate the VC Tunneled Base but instead I chose the regular base (because of the order of questions here):

----------------------------------------------------
Select 1 piece among the following:
  3 VC Active Guerrillas, 1 VC Base, 1 VC Tunneled Base

How many VC Bases (0 - 1): 1
Remove 1 VC Base from Tay Ninh to AVAILABLE

I realized after that I should have put 0 as response, and (I presume) the next question would have been "How many VC Tunneled Bases (0-1)". In any case, I figured it was no big deal, I would simply adjust afterwards. However, when I tried to adjust it, I couldn't.

Pieces in Tay Ninh
----------------------------------------------------
3 US Troops, 4 ARVN Troops, 6 NVA Troops, 1 NVA Underground Guerrilla, 
2 NVA Active Guerrillas, 1 NVA Base, 3 VC Active Guerrillas, 
1 VC Tunneled Base

Available Pieces
----------------------------------------------------
6 US Troops, 1 ARVN Base, 21 NVA Troops, 4 NVA Underground Guerrillas, 
3 VC Underground Guerrillas, 1 VC Base

Select type of piece to adjust:
====================================================
 1) US Troops
 2) ARVN Troops
 3) NVA Troops
 4) NVA Underground Guerrillas
 5) NVA Active Guerrillas
 6) NVA Bases
 7) VC Underground Guerrillas
 8) VC Active Guerrillas
 9) VC Tunneled Bases
10) Finished adjusting pieces in Tay Ninh
----------------------------------------------------
Selection: 

I would expect there to be an option for NVA tunneled bases since, although rare, it is possible to make them tunneled (such as with infiltrating an already-tunneled VC base). I consider this a bug and not an enhancement, since it's something that's missing.

@richardmtl richardmtl added the bug Something isn't working label Feb 12, 2023
@sellmerfud
Copy link
Owner

Bases and Tunneled Bases are represented as different entities with in the code.

So what is going on here is that there are two bases currently in Tay Ninh: A Tunneled VC Base and an Untunneled NVA Base.
The adjust code will only let you change the number of those entities. So to change the NVA Base into a Tunneled base you must first remove the NVA Bases (adjust NVA Bases to zero). Then you will see that an option for NVA Tunneled Bases will appear in the menu. You can then select it to add the Tunneled Base.

@sellmerfud
Copy link
Owner

sellmerfud commented Feb 12, 2023

Also it bears pointing out that to add a piece to a space, the piece must be in the Available Box. This means in the case where the piece you wish to add to a space is not available it must be taken from somewhere first with a separate Adjust command. This includes if you wanted to move a piece from the Casualties Box or the Out of Play Box. The piece must first be adjusted out of that box. And the the space can be adjusted to add the new available piece.

@richardmtl
Copy link
Collaborator Author

Ah, understood. So the code doesn't let me adjust things willy-nilly; it hews to the space limits etc. Ok, that's clearer now. Closing!

@richardmtl richardmtl added invalid This doesn't seem right wontfix This will not be worked on and removed bug Something isn't working labels Feb 12, 2023
@sellmerfud sellmerfud removed invalid This doesn't seem right wontfix This will not be worked on labels Feb 19, 2023
@sellmerfud sellmerfud reopened this Feb 19, 2023
@sellmerfud sellmerfud added this to the Version 0.27 milestone Feb 19, 2023
@sellmerfud
Copy link
Owner

I reworked code for adjusting pieces for a selected space on the map.
You can now move pieces to/from other spaces and you can move pieces between the space and the available/casualties/out of play boxes.
When moving a base/or tunneled base you can select either type from the source and place it in a single command.
When moving a pieced that can be flipped (guerrilla, ranger, irregular) you specify the type active/undergound to be place in the destination, but you can select both active and underground pieces in the source.

This allow you to, for example, move 3 the active guerrillas in Tay Ninh to Saigon as underground guerrillas.
Or you could select an NVA Base in the Available box and move it to a space as a Tunneled base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants