Write a dont-break verifyRelease plugin #65

Open
boennemann opened this Issue Aug 23, 2015 · 6 comments

Comments

Projects
None yet
6 participants
@boennemann
Member

boennemann commented Aug 23, 2015

dont-break is a very nice module by @bahmutov, that can detect breaking changes, by running your dependents tests against the current version of your code base.

I'd love to see a semantic-release verifyRelease plugin (just like cracks), but I might not immediately have the time to do it myself.

If you want to give this a shot let me know in this issue and I'm happy to help wherever I can. You can reach me in the semantic-release gitter room, or on Twitter.

@bahmutov

This comment has been minimized.

Show comment
Hide comment
@bahmutov

bahmutov Aug 23, 2015

Contributor

will consider if I have time. Right now I am thinking of writing a tool that would configure all project-related services: travis, semantic release, david dependencies, codacy in a single command.

Contributor

bahmutov commented Aug 23, 2015

will consider if I have time. Right now I am thinking of writing a tool that would configure all project-related services: travis, semantic release, david dependencies, codacy in a single command.

@ariporad

This comment has been minimized.

Show comment
Hide comment
@ariporad

ariporad Aug 23, 2015

Contributor

That sounds awesome! And if you're willing, I'd love to help.

Thanks!Ari

On Sun, Aug 23, 2015 at 2:17 PM, Gleb Bahmutov notifications@github.com
wrote:

will consider if I have time. Right now I am thinking of writing a tool that would configure all project-related services: travis, semantic release, david dependencies, codacy in a single command.

Reply to this email directly or view it on GitHub:
#65 (comment)

Contributor

ariporad commented Aug 23, 2015

That sounds awesome! And if you're willing, I'd love to help.

Thanks!Ari

On Sun, Aug 23, 2015 at 2:17 PM, Gleb Bahmutov notifications@github.com
wrote:

will consider if I have time. Right now I am thinking of writing a tool that would configure all project-related services: travis, semantic release, david dependencies, codacy in a single command.

Reply to this email directly or view it on GitHub:
#65 (comment)

@boennemann

This comment has been minimized.

Show comment
Hide comment
@boennemann

boennemann Aug 24, 2015

Member

@bahmutov Awesome, thank you!

Member

boennemann commented Aug 24, 2015

@bahmutov Awesome, thank you!

@gajus

This comment has been minimized.

Show comment
Hide comment
@gajus

gajus Feb 2, 2016

I don't understand. https://github.com/semantic-release/semantic-release is advertising this as a feature.

Detect breaking changes using your dependents’ test suites: Help out! Implement the dont-break plugin

Oh, no it doesn't. Reading a second time – "Help out!" is supposed to indicate it is an upcoming feature. Thats a bit misleading.

Nevertheless, this would be a deal breaker.

gajus commented Feb 2, 2016

I don't understand. https://github.com/semantic-release/semantic-release is advertising this as a feature.

Detect breaking changes using your dependents’ test suites: Help out! Implement the dont-break plugin

Oh, no it doesn't. Reading a second time – "Help out!" is supposed to indicate it is an upcoming feature. Thats a bit misleading.

Nevertheless, this would be a deal breaker.

@bahmutov

This comment has been minimized.

Show comment
Hide comment
@bahmutov

bahmutov Feb 14, 2017

Contributor

I believe my plugin https://github.com/bahmutov/dont-crack already does that

Contributor

bahmutov commented Feb 14, 2017

I believe my plugin https://github.com/bahmutov/dont-crack already does that

@ianwremmel ianwremmel referenced this issue in webex/ciscospark-eslint-config Sep 6, 2017

Open

CircleCI #20

@pvdlg pvdlg added new plugin and removed feature labels Dec 16, 2017

@felixfbecker

This comment has been minimized.

Show comment
Hide comment
@felixfbecker

felixfbecker Dec 23, 2017

Contributor

My question would be how to do this before an accidental breaking change is merged into master, i.e. on a PR? Using plain dont-break works, but will not consider whether the commit messages include BREAKING CHANGE

Contributor

felixfbecker commented Dec 23, 2017

My question would be how to do this before an accidental breaking change is merged into master, i.e. on a PR? Using plain dont-break works, but will not consider whether the commit messages include BREAKING CHANGE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment