Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add logging for when ssh falls back to http #1639

Merged
merged 1 commit into from Sep 17, 2020

Conversation

@Alphy11
Copy link
Contributor

@Alphy11 Alphy11 commented Sep 17, 2020

When setting up semantic release in CI, the debug logging does not provide enough context on why it is trying to push via https, and is hard to debug without deeply reading the code. Adding some debug logging to indicate that will make it easier to know why you're calling git via https.

gr2m
gr2m approved these changes Sep 17, 2020
Copy link
Member

@gr2m gr2m left a comment

thanks for digging through the code and making it easier for future users to identify the same problem!

@gr2m gr2m merged commit b4c5d0a into semantic-release:master Sep 17, 2020
4 checks passed
@semantic-release-bot
Copy link
Collaborator

@semantic-release-bot semantic-release-bot commented Sep 17, 2020

🎉 This PR is included in version 17.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

pull bot added a commit to rikhoffbauer/semantic-release that referenced this issue Sep 17, 2020
Co-authored-by: thomas williams <thomas.williams@thetradedesk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants