Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Throw an Error if package.json has duplicate "repository" key #1656

Merged

Conversation

@gr2m
Copy link
Member

@gr2m gr2m commented Oct 11, 2020

addresses bad DX reported in #1655 /cc @kentcdodds @travi

travi
travi approved these changes Oct 11, 2020
Copy link
Member

@travi travi left a comment

one typo, but otherwise looks great 👍🏼

@gr2m
Copy link
Member Author

@gr2m gr2m commented Oct 11, 2020

where's the typo?

CONTRIBUTING.md Outdated Show resolved Hide resolved
@travi
Copy link
Member

@travi travi commented Oct 11, 2020

where's the typo?

looks like you found my comment. surprised that it didnt show up in this thread. must be because i still approved 🤷🏼

Copy link
Contributor

@kentcdodds kentcdodds left a comment

Nice!

@gr2m gr2m merged commit b8fb35c into master Oct 11, 2020
4 checks passed
@gr2m gr2m deleted the 1655/throw-error-on-duplicate-repository-key-in-package-json branch Oct 11, 2020
@semantic-release-bot
Copy link
Collaborator

@semantic-release-bot semantic-release-bot commented Oct 11, 2020

🎉 This PR is included in version 17.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

pull bot added a commit to rikhoffbauer/semantic-release that referenced this issue Oct 11, 2020
travi added a commit that referenced this issue Oct 12, 2020
@travi
Copy link
Member

@travi travi commented Oct 12, 2020

i reverted this change for now in order to give us time to understand #1657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants