Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't parse port as part of the path in repository URLs #1671

Merged
merged 1 commit into from Oct 28, 2020

Conversation

@arcln
Copy link
Contributor

@arcln arcln commented Oct 28, 2020

See #1670 for details about the issue. Here is a regular expression proposal that supports port parsing :

^(?!.+:\/\/)(?:(?<auth>.*)@)?(?<host>.*?):(?<port>\d+)?:?\/?(?<path>.*)$

It is parsing as expected the following example URLs :

localhost:2080/git/test.git
localhost.null:2080/git/test.git
localhost.null:git/test.git
localhost.null:/git/test.git

localhost:2080/group/git/test.git
localhost.null:2080/group/git/test.git
localhost.null:group/git/test.git
localhost.null:/group/git/test.git

git@localhost:2080/git/test.git
git@localhost.null:2080/git/test.git
git@localhost.null:git/test.git
git@localhost.null:/git/test.git

git:pass@localhost:2080/git/test.git
git:pass@localhost.null:2080/git/test.git
git:pass@localhost.null:git/test.git
git:pass@localhost.null:/git/test.git
gr2m
gr2m approved these changes Oct 28, 2020
Copy link
Member

@gr2m gr2m left a comment

great, thank you!

@gr2m gr2m merged commit 77a75f0 into semantic-release:master Oct 28, 2020
4 checks passed
@gr2m gr2m linked an issue that may be closed by this pull request Oct 28, 2020
pull bot added a commit to rikhoffbauer/semantic-release that referenced this issue Oct 29, 2020
@semantic-release-bot
Copy link
Collaborator

@semantic-release-bot semantic-release-bot commented Oct 29, 2020

🎉 This PR is included in version 17.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants