Transform tag to commit sha when getting notes #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2020
Xunnamius
changed the title
Xunnamius
force-pushed
the
contrib
branch
2 times, most recently
from
f43f55c
to
29fe376
Compare
gr2m
reviewed
Aug 29, 2021
| @@ -306,7 +306,8 @@ async function isBranchUpToDate(repositoryUrl, branch, execaOptions) { | |||
| */ | |||
| async function getNote(ref, execaOptions) { | |||
| try { | |||
| return JSON.parse((await execa('git', ['notes', '--ref', GIT_NOTE_REF, 'show', ref], execaOptions)).stdout); | |||
| const commit = (await execa('git', ['log', '-1', '--pretty=format:%H', ref], execaOptions)).stdout; | |||
| return JSON.parse((await execa('git', ['notes', '--ref', GIT_NOTE_REF, 'show', commit], execaOptions)).stdout); | |||
There was a problem hiding this comment.
Hey @Xunnamius do you think you could add a test to prevent regressions in future?
As mentioned in #1708 we appreciate your thorough research and when in doubt I'd rather merge your change and trust our test suite that no existing use case broke.
@travi brought up this:
My only concern would be if it is something that considers details across branches. I think we're should keep things working from the history of a single branch.
Any thoughts?
This reverts commit 62930d0.
|
Hello, any update ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1708