Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add logging for top-level errors #1736

Merged
merged 1 commit into from Jan 15, 2021

Conversation

@tzimmermann
Copy link
Contributor

@tzimmermann tzimmermann commented Jan 15, 2021

Log errors in the main binary to the console to help with debugging.
I wasn't sure how to add tests for this, as I couldn't find any existing tests for that file.

closes #1734

Log errors in the main binary to the console to help with debugging.

closes semantic-release#1734
gr2m
gr2m approved these changes Jan 15, 2021
Copy link
Member

@gr2m gr2m left a comment

I wasn't sure how to add tests for this, as I couldn't find any existing tests for that file.

that's okay. Logging the error is better than not logging the error at all. We can still figure out tests later

Loading

@gr2m gr2m merged commit 9f57b84 into semantic-release:master Jan 15, 2021
2 of 3 checks passed
Loading
@semantic-release-bot
Copy link
Collaborator

@semantic-release-bot semantic-release-bot commented Jan 15, 2021

🎉 This PR is included in version 17.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Loading

Xunnamius added a commit to Xunnamius/semantic-release that referenced this issue Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants